added a comment indicating how and where to fix 42743 should

we decide to do so.

diff --git a/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java b/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java
index e81c43ff2f55142adbd2097ca0d2d96482d067b3..bbb56b777d9b5c33280de0a0e4ad2777cbd46b86 100644 (file)
--- a/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java
+++ b/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java
@@ -1234,6 +1234,12 @@ public class BcelShadow extends Shadow {
         InstructionList handler = new InstructionList();        
         BcelVar exceptionVar = genTempVar(catchType);
         exceptionVar.appendStore(handler, fact);
+        
+        // ENH 42743 suggests that we don't soften runtime exceptions.
+        // To implement that, would need to add instructions into the handler
+        // stream here to test if exceptionVar is an instanceof RuntimeException,
+        // and if it is, just re-throw it without softening.
+        // (Not yet implemented obviously).
 
                handler.append(fact.createNew(NameMangler.SOFT_EXCEPTION_TYPE));
                handler.append(InstructionFactory.createDup(1));