Explicitly mark switch case fall through

This allows us to separate accidental fall through from explicit ones,
which allows us to turn on such checks in the compiler.

diff --git a/common/rfb/CSecurityRSAAES.cxx b/common/rfb/CSecurityRSAAES.cxx
index 208bcc2f4e876639d21d25a4c289c4d3d57d8784..c84422b677ddfa2a19abb12871d5d70e22dbff8d 100644 (file)
--- a/common/rfb/CSecurityRSAAES.cxx
+++ b/common/rfb/CSecurityRSAAES.cxx
@@ -106,17 +106,20 @@ bool CSecurityRSAAES::processMsg()
       writePublicKey();
       writeRandom();
       state = ReadRandom;
+      /* fall through */
     case ReadRandom:
       if (!readRandom())
         return false;
       setCipher();
       writeHash();
       state = ReadHash;
+      /* fall through */
     case ReadHash:
       if (!readHash())
         return false;
       clearSecrets();
       state = ReadSubtype;
+      /* fall through */
     case ReadSubtype:
       if (!readSubtype())
         return false;

diff --git a/common/rfb/JpegCompressor.cxx b/common/rfb/JpegCompressor.cxx
index 0ecc6de937e90168367c0f10fa17d7aff8c9ed70..24a62a865d42d3cf7b3c8409157a316c0df06475 100644 (file)
--- a/common/rfb/JpegCompressor.cxx
+++ b/common/rfb/JpegCompressor.cxx
@@ -232,6 +232,7 @@ void JpegCompressor::compress(const rdr::U8 *buf, int stride, const Rect& r,
     break;
   case subsampleGray:
     jpeg_set_colorspace(cinfo, JCS_GRAYSCALE);
+    // fall through
   default:
     cinfo->comp_info[0].h_samp_factor = 1;
     cinfo->comp_info[0].v_samp_factor = 1;

diff --git a/common/rfb/PixelFormat.inl b/common/rfb/PixelFormat.inl
index 5a40379a37fe6b2b0153082a1898e0c956c67c27..3a0bfe4974bf02067301e55a1e5161812887583b 100644 (file)
--- a/common/rfb/PixelFormat.inl
+++ b/common/rfb/PixelFormat.inl
@@ -30,8 +30,10 @@ inline Pixel PixelFormat::pixelFromBuffer(const rdr::U8* buffer) const
     case 32:
       p |= ((Pixel)*(buffer++)) << 24;
       p |= ((Pixel)*(buffer++)) << 16;
+      /* fall through */
     case 16:
       p |= ((Pixel)*(buffer++)) << 8;
+      /* fall through */
     case 8:
       p |= *buffer;
     }
@@ -57,8 +59,10 @@ inline void PixelFormat::bufferFromPixel(rdr::U8* buffer, Pixel p) const
     case 32:
       *(buffer++) = (p >> 24) & 0xff;
       *(buffer++) = (p >> 16) & 0xff;
+      /* fall through */
     case 16:
       *(buffer++) = (p >>  8) & 0xff;
+      /* fall through */
     case 8:
       *(buffer++) = (p >>  0) & 0xff;
     }

diff --git a/vncviewer/DesktopWindow.cxx b/vncviewer/DesktopWindow.cxx
index 1bd66b9284a3f5232d6084fd10b4b544a6705fe1..70573a28bc864d8c5123164a3d8a3270d4d4ae6c 100644 (file)
--- a/vncviewer/DesktopWindow.cxx
+++ b/vncviewer/DesktopWindow.cxx
@@ -840,6 +840,7 @@ int DesktopWindow::handle(int event)
   case FL_ENTER:
       if (keyboardGrabbed)
           grabPointer();
+      /* fall through */
   case FL_LEAVE:
   case FL_DRAG:
   case FL_MOVE:

diff --git a/vncviewer/OptionsDialog.cxx b/vncviewer/OptionsDialog.cxx
index c756f3a8befce7abd2be3709a3ebeb5bc8433f00..d0481708724f0dc7829c07ffb0e1dc4428fc08d7 100644 (file)
--- a/vncviewer/OptionsDialog.cxx
+++ b/vncviewer/OptionsDialog.cxx
@@ -295,6 +295,7 @@ void OptionsDialog::loadOptions(void)
     case secTypeRA2ne:
     case secTypeRAne256:
       authVncCheckbox->value(true);
+      /* fall through */
     case secTypeDH:
     case secTypeMSLogonII:
       encNoneCheckbox->value(true);

diff --git a/win/winvnc/STrayIcon.cxx b/win/winvnc/STrayIcon.cxx
index 83afbed280d58ff41c1f2ab2960a56ae95a1cab7..2cf2475291f7cce864a052c84a5644097fb5b312 100644 (file)
--- a/win/winvnc/STrayIcon.cxx
+++ b/win/winvnc/STrayIcon.cxx
@@ -189,6 +189,7 @@ public:
           return thread.server.disconnectClients("IPC disconnect") ? 1 : 0;
         case 3:
           thread.server.setClientsStatus(&CPanel->ListConnStatus);
+          /* fall through */
         case 4:
           thread.server.getClientsInfo(&LCInfo);
           CPanel->UpdateListView(&LCInfo);