]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-18130 Breadcrumb region is missing appropriate roles and/or attributes
authorstanislavh <stanislav.honcharov@sonarsource.com>
Fri, 10 Feb 2023 11:20:50 +0000 (12:20 +0100)
committersonartech <sonartech@sonarsource.com>
Fri, 10 Feb 2023 20:02:45 +0000 (20:02 +0000)
server/sonar-web/src/main/js/app/styles/init/lists.css
server/sonar-web/src/main/js/apps/quality-profiles/details/ProfileHeader.tsx
sonar-core/src/main/resources/org/sonar/l10n/core.properties

index b61d1d68adbfe2bfbaa8acb6475818d896046a8b..a6bea0b85bbc5d7a2e7b5db26a3f06f20973798a 100644 (file)
@@ -46,6 +46,15 @@ ol.list-styled {
   list-style: none;
 }
 
+.list-breadcrumbs > li {
+  display: inline-block;
+}
+
+.list-breadcrumbs > li:not(:first-of-type)::before {
+  content: '/' / '';
+  margin-inline: 3px;
+}
+
 ul.list-inline > li,
 div.list-inline > div {
   display: inline-block;
index c02116e3877993a413140dcf36a86b4181826288..b128ae8bdd867ae5ea7bb555eeff3a530fc3fa85 100644 (file)
@@ -65,13 +65,18 @@ export default function ProfileHeader(props: Props) {
           )}
         />
       )}
-      <div className="note spacer-bottom">
-        <NavLink end={true} to={PROFILE_PATH}>
-          {translate('quality_profiles.page')}
-        </NavLink>
-        {' / '}
-        <Link to={getProfilesForLanguagePath(profile.language)}>{profile.languageName}</Link>
-      </div>
+      <nav className="note spacer-bottom" aria-label={translate('breadcrumbs')}>
+        <ul className="list-breadcrumbs">
+          <li>
+            <NavLink end={true} to={PROFILE_PATH}>
+              {translate('quality_profiles.page')}
+            </NavLink>
+          </li>
+          <li>
+            <Link to={getProfilesForLanguagePath(profile.language)}>{profile.languageName}</Link>
+          </li>
+        </ul>
+      </nav>
 
       <h1 className="page-title">
         <ProfileLink language={profile.language} name={profile.name}>
index e212d87eba05e889ab7fce61ea51b584a5cb9caa..9ff58aa9d78f7d82a3b57a3eac253999b175d6e4 100644 (file)
@@ -29,6 +29,7 @@ beta=BETA
 blocker=Blocker
 bold=Bold
 branch=Branch
+breadcrumbs=Breadcrumbs
 by_=by
 calendar=Calendar
 cancel=Cancel