]> source.dussan.org Git - sonarqube.git/commitdiff
removed un-necessary try/catch
authorStephane Gamard <stephane.gamard@sonarsource.com>
Tue, 14 Oct 2014 13:41:28 +0000 (15:41 +0200)
committerStephane Gamard <stephane.gamard@sonarsource.com>
Wed, 15 Oct 2014 07:48:03 +0000 (09:48 +0200)
server/sonar-server/src/main/java/org/sonar/server/db/BaseDao.java
server/sonar-server/src/test/java/org/sonar/server/component/db/ComponentDaoTest.java

index 71426bec5417d4a243aa64046e96d13874d6ba47..b9f51f14b413cb0b1999ce01fee3bc7245c4bc5c 100644 (file)
@@ -360,15 +360,11 @@ public abstract class BaseDao<MAPPER, DTO extends Dto<KEY>, KEY extends Serializ
       LOGGER.warn("Synchronizer should only be used with BatchSession!");
     }
 
-    try {
-      DbSynchronizationHandler handler = getSynchronizationResultHandler(session, params);
-      session.select(getSynchronizeStatementFQN(), getSynchronizationParams(date, params), handler);
-      handler.enqueueCollected();
-      session.enqueue(new RefreshIndex(this.getIndexType()));
-      session.commit();
-    } catch (Exception e) {
-      throw new IllegalStateException(e);
-    }
+    DbSynchronizationHandler handler = getSynchronizationResultHandler(session, params);
+    session.select(getSynchronizeStatementFQN(), getSynchronizationParams(date, params), handler);
+    handler.enqueueCollected();
+    session.enqueue(new RefreshIndex(this.getIndexType()));
+    session.commit();
   }
 
   private String getSynchronizeStatementFQN() {
index bb492c16a0b4259d17498c6f4a751584b1c64e59..19017b84411fae3d4a52372be7d285cce6778b6d 100644 (file)
@@ -19,6 +19,7 @@
  */
 package org.sonar.server.component.db;
 
+import org.apache.ibatis.exceptions.PersistenceException;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
@@ -362,7 +363,7 @@ public class ComponentDaoTest extends AbstractDaoTestCase {
     checkTable("delete", "projects");
   }
 
-  @Test(expected = IllegalStateException.class)
+  @Test(expected = PersistenceException.class)
   public void synchronize_after() {
     dao.synchronizeAfter(session, new Date(0L));
   }