]> source.dussan.org Git - vaadin-framework.git/commitdiff
Fix some modern browsers tests failures.
authorAleksi Hietanen <aleksi@vaadin.com>
Tue, 29 Nov 2016 13:37:56 +0000 (15:37 +0200)
committerPekka Hyvönen <pekka@vaadin.com>
Fri, 9 Dec 2016 07:39:00 +0000 (09:39 +0200)
Change-Id: I2a89d3493e2f98ab1b9a0666d9dc075a2457e432

uitest/src/test/java/com/vaadin/tests/components/abstractembedded/EmbeddedWithNullSourceTest.java
uitest/src/test/java/com/vaadin/tests/components/flash/FlashIsVisibleTest.java

index 840af1e1e7a1ca4ac660e4c3b92ffc8a79969c7b..b3ce673d9f00616de0bfcfdda593c463da043b83 100644 (file)
@@ -31,7 +31,8 @@ public class EmbeddedWithNullSourceTest extends MultiBrowserTest {
     public List<DesiredCapabilities> getBrowsersToTest() {
         // No Flash on PhantomJS, IE 11 has a timeout issue, looks like a
         // IEDriver problem, not reproduced running locally.
-        return getBrowserCapabilities(Browser.CHROME, Browser.FIREFOX);
+        // Flash is disabled in Chrome.
+        return getBrowserCapabilities(Browser.FIREFOX);
     }
 
     @Test
index 4a18d4d8a21e6502988048445a7401770e82322e..dd96bdf3863e3f5b1966e72f4137e53617e722e0 100644 (file)
@@ -12,7 +12,10 @@ public class FlashIsVisibleTest extends MultiBrowserTest {
     @Override
     public List<DesiredCapabilities> getBrowsersToTest() {
         // FF and PhantomJS fail at Flash and ShiftClick
-        return getBrowsersSupportingShiftClick();
+        List<DesiredCapabilities> capabilities = getBrowsersSupportingShiftClick();
+        // Flash support in Chrome is disabled
+        capabilities.removeAll(getBrowserCapabilities(Browser.CHROME));
+        return capabilities;
     }
 
     @Test