Clone properties when creating ProjectDefinition

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/batch/bootstrap/ProjectDefinition.java b/sonar-plugin-api/src/main/java/org/sonar/api/batch/bootstrap/ProjectDefinition.java
index e824d4e0a8732bffe5533a4eace42dd4ce7111e3..b1b21a1bb3801436f4754318eb379f8916164de9 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/batch/bootstrap/ProjectDefinition.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/batch/bootstrap/ProjectDefinition.java
@@ -59,7 +59,7 @@ public final class ProjectDefinition implements BatchComponent {
   }
 
   public static ProjectDefinition create(Properties properties) {
-    return new ProjectDefinition(properties);
+    return new ProjectDefinition((Properties)properties.clone());
   }
 
   public static ProjectDefinition create() {

diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/batch/bootstrap/ProjectDefinitionTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/batch/bootstrap/ProjectDefinitionTest.java
index 581e9ff3361b6d44fa7ca4797924e6d329338e85..ad1cf8686661892dd26cd368c09d77f2a4bb9dc3 100644 (file)
--- a/sonar-plugin-api/src/test/java/org/sonar/api/batch/bootstrap/ProjectDefinitionTest.java
+++ b/sonar-plugin-api/src/test/java/org/sonar/api/batch/bootstrap/ProjectDefinitionTest.java
@@ -146,6 +146,17 @@ public class ProjectDefinitionTest {
     assertThat(root.getTestDirs().size(), is(0));
   }
 
+  @Test
+  public void shouldCloneProperties()  {
+    Properties rootProps = new Properties();
+    rootProps.setProperty(CoreProperties.PROJECT_NAME_PROPERTY, "root");
+    ProjectDefinition def = ProjectDefinition.create(rootProps);
+    def.setName("child");
+
+    assertThat(def.getName(), is("child"));
+    assertThat(rootProps.getProperty(CoreProperties.PROJECT_NAME_PROPERTY), is("root"));
+  }
+
   private static void assertFiles(List<String> paths, String... values) {
     assertThat(paths.size(), is(values.length));
     for (int i = 0; i < values.length; i++) {