]> source.dussan.org Git - jgit.git/commitdiff
RebaseCommand: Remove unnecessary fall through comments 67/127067/1
authorJonathan Nieder <jrn@google.com>
Sat, 4 Aug 2018 21:00:26 +0000 (14:00 -0700)
committerJonathan Nieder <jrn@google.com>
Sat, 4 Aug 2018 21:04:29 +0000 (14:04 -0700)
It's easier to read a list of cases

case A:
case B:
case C:
... do something ...;
break;

without intervening "// fall through" lines separating the cases.

This also makes it clearer that JGit uses "$FALL-THROUGH$", not "fall
through", to suppress fallthrough warnings in switch statements.
Eclipse does not pay attention to the second comment style.

Change-Id: I5279a727aee2868854d06bfcaac8cb8186b4299e
Signed-off-by: Jonathan Nieder <jrn@google.com>
org.eclipse.jgit/src/org/eclipse/jgit/api/RebaseCommand.java

index 98c16b893175b88132425f4d978632699a0b8d0b..1783c4193e387fe123cab462961dccd0ff3a24e4 100644 (file)
@@ -275,9 +275,7 @@ public class RebaseCommand extends GitCommand<RebaseResult> {
                                        throw new JGitInternalException(ioe.getMessage(), ioe);
                                }
                        case PROCESS_STEPS:
-                               // fall through
                        case SKIP:
-                               // fall through
                        case CONTINUE:
                                String upstreamCommitId = rebaseState.readFile(ONTO);
                                try {