]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-4025 Add filter description to filter widget
authorFabrice Bellingard <fabrice.bellingard@sonarsource.com>
Fri, 11 Jan 2013 16:23:34 +0000 (17:23 +0100)
committerFabrice Bellingard <fabrice.bellingard@sonarsource.com>
Fri, 11 Jan 2013 16:32:38 +0000 (17:32 +0100)
plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/widgets/MeasureFilterListWidget.java
plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/widgets/MeasureFilterTreemapWidget.java
plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/measure_filter_list.html.erb
plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/measure_filter_treemap.html.erb

index a551f35d74e0d9b700736a93a53728717999f2a4..3376cf9103171820b20dc89aabe3319ee3651e44 100644 (file)
@@ -31,11 +31,13 @@ import static org.sonar.api.web.WidgetScope.GLOBAL;
 @WidgetScope(GLOBAL)
 @WidgetProperties({
   @WidgetProperty(key = MeasureFilterListWidget.FILTER_PROPERTY, type = WidgetPropertyType.FILTER, optional = false),
-  @WidgetProperty(key = MeasureFilterListWidget.PAGE_SIZE_PROPERTY, type = WidgetPropertyType.INTEGER, defaultValue = "30")
+  @WidgetProperty(key = MeasureFilterListWidget.PAGE_SIZE_PROPERTY, type = WidgetPropertyType.INTEGER, defaultValue = "30"),
+  @WidgetProperty(key = MeasureFilterListWidget.DISPLAY_FILTER_DESCRIPTION, type = WidgetPropertyType.BOOLEAN, defaultValue = "false")
 })
 public class MeasureFilterListWidget extends CoreWidget {
   public static final String FILTER_PROPERTY = "filter";
   public static final String PAGE_SIZE_PROPERTY = "pageSize";
+  public static final String DISPLAY_FILTER_DESCRIPTION = "displayFilterDescription";
   public static final String ID = "measure_filter_list";
 
   public MeasureFilterListWidget() {
index 267b5b48573a8ce361a873047c63dbaf68379ab3..6bf98555097e5c2d8f5cedf125fc28765c9e5b93 100644 (file)
@@ -33,13 +33,16 @@ import static org.sonar.api.web.WidgetScope.GLOBAL;
   @WidgetProperty(key = MeasureFilterTreemapWidget.FILTER_PROPERTY, type = WidgetPropertyType.FILTER, optional = false),
   @WidgetProperty(key = MeasureFilterTreemapWidget.SIZE_METRIC_PROPERTY, type = WidgetPropertyType.METRIC, optional = true),
   @WidgetProperty(key = MeasureFilterTreemapWidget.COLOR_METRIC_PROPERTY, type = WidgetPropertyType.METRIC, optional = true, options = "type:PERCENT"),
-  @WidgetProperty(key = MeasureFilterTreemapWidget.HEIGHT_PERCENTS_PROPERTY, type = WidgetPropertyType.INTEGER, optional = true, defaultValue = "55", description = "Height in percents of width")
+  @WidgetProperty(key = MeasureFilterTreemapWidget.HEIGHT_PERCENTS_PROPERTY, type = WidgetPropertyType.INTEGER, optional = true, defaultValue = "55",
+    description = "Height in percents of width"),
+  @WidgetProperty(key = MeasureFilterListWidget.DISPLAY_FILTER_DESCRIPTION, type = WidgetPropertyType.BOOLEAN, defaultValue = "false")
 })
 public class MeasureFilterTreemapWidget extends CoreWidget {
   public static final String FILTER_PROPERTY = "filter";
   public static final String SIZE_METRIC_PROPERTY = "sizeMetric";
   public static final String COLOR_METRIC_PROPERTY = "colorMetric";
   public static final String HEIGHT_PERCENTS_PROPERTY = "heightInPercents";
+  public static final String DISPLAY_FILTER_DESCRIPTION = "displayFilterDescription";
   public static final String ID = "measure_filter_treemap";
 
   public MeasureFilterTreemapWidget() {
index 7ec7a3bbe7b09283fe05f43f99cfb51f0ca236f6..c0e810f71d9097df40086dd9ee1eda94160d2f18 100644 (file)
        filter.execute(self, :user => current_user)
        @widget_title = link_to h(filter.name), {:controller => 'measures', :action => 'filter', :id => filter.id, :display => 'list'}
 %>
+
+  <% if widget_properties['displayFilterDescription'] && !filter.description.blank? %>
+    <div style="padding-bottom: 5px">
+      <span class="note"><%= h filter.description -%></span>
+    </div>
+  <% end %>
+
     <%= render :partial => "measures/display_#{filter.display.key}", :locals => {:edit_mode => false, :filter => filter, :widget_id => widget.id} -%>
 <%
      end
index 259ed662c38674343cec081e2d5dc6214bedff3d..4cf3eb1ae503b6c9cd044a6a322e1b214c3cfcaf 100644 (file)
 
        @widget_title = link_to h(filter.name), url_options
 %>
+
+  <% if widget_properties['displayFilterDescription'] && !filter.description.blank? %>
+    <div style="padding-bottom: 5px">
+      <span class="note"><%= h filter.description -%></span>
+    </div>
+  <% end %>
+
     <%= render :partial => "measures/display_#{filter.display.key}", :locals => {:edit_mode => false, :widget_id => widget.id, :filter => filter} %>
 <%
      end