Fixed a bug in clone where it wouldn't work on an XML node in IE. Also added unit...

diff --git a/src/core.js b/src/core.js
index 660f7eee675b311e8f8754111cb78ccbe61fa7da..a37ae783f80d76e6293230a0a1ba7918c003af41 100644 (file)
--- a/src/core.js
+++ b/src/core.js
@@ -290,7 +290,7 @@ jQuery.fn = jQuery.prototype = {
        clone: function( events ) {
                // Do the clone
                var ret = this.map(function(){
-                       if ( jQuery.browser.msie ) {
+                       if ( jQuery.browser.msie && !jQuery.isXMLDoc(this) ) {
                                // IE copies events bound via attachEvent when
                                // using cloneNode. Calling detachEvent on the
                                // clone will also remove the events from the orignal

diff --git a/test/unit/core.js b/test/unit/core.js
index 3aa66b32461229e8e661c7c41ebeea06bc072049..4e774857853490b82400ba5c29b69ed96fc04a93 100644 (file)
--- a/test/unit/core.js
+++ b/test/unit/core.js
@@ -864,7 +864,7 @@ test("find(String)", function() {
 });
 
 test("clone()", function() {
-       expect(4);
+       expect(6);
        ok( 'This is a normal link: Yahoo' == $('#en').text(), 'Assert text for #en' );
        var clone = $('#yahoo').clone();
        ok( 'Try them out:Yahoo' == $('#first').append(clone).text(), 'Check for clone' );
@@ -872,6 +872,16 @@ test("clone()", function() {
        // using contents will get comments regular, text, and comment nodes
        var cl = $("#nonnodes").contents().clone();
        ok( cl.length >= 2, "Check node,textnode,comment clone works (some browsers delete comments on clone)" );
+
+       stop();
+       $.get("data/dashboard.xml", function (xml) {
+               var root = $(xml.documentElement).clone();
+               $("tab:first", xml).text("origval");
+               $("tab:first", root).text("cloneval");
+               equals($("tab:first", xml).text(), "origval", "Check original XML node was correctly set");
+               equals($("tab:first", root).text(), "cloneval", "Check cloned XML node was correctly set");
+               start();
+       });
 });
 
 test("is(String)", function() {