]> source.dussan.org Git - nextcloud-server.git/commitdiff
Allow dir-listing also when one child is blocked by access control
authorJoas Schilling <coding@schilljs.com>
Fri, 26 May 2017 10:36:42 +0000 (12:36 +0200)
committerJoas Schilling <coding@schilljs.com>
Fri, 16 Jun 2017 08:47:46 +0000 (10:47 +0200)
Signed-off-by: Joas Schilling <coding@schilljs.com>
apps/dav/lib/Connector/Sabre/FilesPlugin.php

index 30eeaaacf6322f0a46e3a203153e9f88d32acbab..efc9a42e5f59de2194468c0cea230e3bbdcbe7f7 100644 (file)
@@ -288,10 +288,16 @@ class FilesPlugin extends ServerPlugin {
                $httpRequest = $this->server->httpRequest;
 
                if ($node instanceof \OCA\DAV\Connector\Sabre\Node) {
+                       /**
+                        * This was disabled, because it made dir listing throw an exception,
+                        * so users were unable to navigate into folders where one subitem
+                        * is blocked by the files_accesscontrol app, see:
+                        * https://github.com/nextcloud/files_accesscontrol/issues/65
                        if (!$node->getFileInfo()->isReadable()) {
                                // avoid detecting files through this means
                                throw new NotFound();
                        }
+                        */
 
                        $propFind->handle(self::FILEID_PROPERTYNAME, function() use ($node) {
                                return $node->getFileId();