Improve quality

diff --git a/sonar-runner-api/src/main/java/org/sonar/runner/impl/ServerConnection.java b/sonar-runner-api/src/main/java/org/sonar/runner/impl/ServerConnection.java
index eb1002f6277b3aab3dda8bd51bc68c2d4b9e0a56..5b306bd3611b602e8c527500064716979564672e 100644 (file)
--- a/sonar-runner-api/src/main/java/org/sonar/runner/impl/ServerConnection.java
+++ b/sonar-runner-api/src/main/java/org/sonar/runner/impl/ServerConnection.java
@@ -143,11 +143,8 @@ class ServerConnection {
     try {
       return downloadString(fullUrl, isCacheEnable);
     } catch (HttpRequest.HttpRequestException e) {
-      if (e.getCause() instanceof ConnectException || e.getCause() instanceof UnknownHostException ||
-        e.getCause() instanceof java.net.SocketTimeoutException) {
-        if (isCacheEnable) {
-          return fallbackToCache(fullUrl, e);
-        }
+      if (isCausedByConnection(e) && isCacheEnable) {
+        return fallbackToCache(fullUrl, e);
       }
 
       logger.error(MessageFormat.format(SONAR_SERVER_CAN_NOT_BE_REACHED, serverUrl));
@@ -155,6 +152,11 @@ class ServerConnection {
     }
   }
 
+  private boolean isCausedByConnection(Exception e) {
+    return e.getCause() instanceof ConnectException || e.getCause() instanceof UnknownHostException ||
+      e.getCause() instanceof java.net.SocketTimeoutException;
+  }
+
   private String fallbackToCache(String fullUrl, HttpRequest.HttpRequestException originalException) {
     logger.info(MessageFormat.format(SONAR_SERVER_CAN_NOT_BE_REACHED + ", trying cache", serverUrl));