]> source.dussan.org Git - vaadin-framework.git/commitdiff
Do not force zero height for empty caption height in FormLayout (#15409)
authorArtur Signell <artur@vaadin.com>
Sat, 11 Jul 2015 18:54:02 +0000 (21:54 +0300)
committerVaadin Code Review <review@vaadin.com>
Wed, 12 Aug 2015 08:28:15 +0000 (08:28 +0000)
Change-Id: I0575556785aa2c5cedb8ec40e2db1ec6644967cc

client/src/com/vaadin/client/ui/VFormLayout.java

index 84a9b4f3dda140c3d3e972468c37d8e90d8fb1d5..bcbb3ebf7bb61f1242bd02f5f7984f7e0fac49dc 100644 (file)
@@ -22,7 +22,6 @@ import java.util.List;
 
 import com.google.gwt.aria.client.Roles;
 import com.google.gwt.dom.client.Element;
-import com.google.gwt.dom.client.Style.Overflow;
 import com.google.gwt.event.dom.client.ClickEvent;
 import com.google.gwt.event.dom.client.ClickHandler;
 import com.google.gwt.user.client.DOM;
@@ -327,22 +326,6 @@ public class VFormLayout extends SimplePanel {
                     requiredFieldIndicator = null;
                 }
             }
-
-            // Workaround for IE weirdness, sometimes returns bad height in some
-            // circumstances when Caption is empty. See #1444
-            // IE7 bugs more often. I wonder what happens when IE8 arrives...
-            // FIXME: This could be unnecessary for IE8+
-            if (BrowserInfo.get().isIE()) {
-                if (isEmpty) {
-                    setHeight("0px");
-                    getElement().getStyle().setOverflow(Overflow.HIDDEN);
-                } else {
-                    setHeight("");
-                    getElement().getStyle().clearOverflow();
-                }
-
-            }
-
         }
 
         /**