should run RetrieveRepoMetas() for empty pr (#15187)

Signed-off-by: a1012112796 <1012112796@qq.com>

diff --git a/routers/repo/compare.go b/routers/repo/compare.go
index a8f4f8add8d67c6867f940e737f26b82073d7aea..38c3005cf744ca4705e9215f38e314e72fd799b0 100644 (file)
--- a/routers/repo/compare.go
+++ b/routers/repo/compare.go
@@ -431,11 +431,15 @@ func PrepareCompareDiff(
                ctx.Data["IsNothingToCompare"] = true
                if unit, err := repo.GetUnit(models.UnitTypePullRequests); err == nil {
                        config := unit.PullRequestsConfig()
+
                        if !config.AutodetectManualMerge {
-                               ctx.Data["AllowEmptyPr"] = !(baseBranch == headBranch && ctx.Repo.Repository.Name == headRepo.Name)
-                       } else {
-                               ctx.Data["AllowEmptyPr"] = false
+                               allowEmptyPr := !(baseBranch == headBranch && ctx.Repo.Repository.Name == headRepo.Name)
+                               ctx.Data["AllowEmptyPr"] = allowEmptyPr
+
+                               return !allowEmptyPr
                        }
+
+                       ctx.Data["AllowEmptyPr"] = false
                }
                return true
        }