]> source.dussan.org Git - redmine.git/commitdiff
Fix redundant 'private' modifier in repositories_git_controller_test.rb (#38091).
authorGo MAEDA <maeda@farend.jp>
Thu, 12 Jan 2023 03:07:39 +0000 (03:07 +0000)
committerGo MAEDA <maeda@farend.jp>
Thu, 12 Jan 2023 03:07:39 +0000 (03:07 +0000)
git-svn-id: https://svn.redmine.org/redmine/trunk@22040 e93f8b46-1217-0410-a6f0-8f06a7374b81

.rubocop_todo.yml
test/functional/repositories_git_controller_test.rb

index 837b12274554d851baa0d8258c5e1aeccb38e3e9..4ac8adddbf2e4fbd64c0895d9acf4ab5bfd291a8 100644 (file)
@@ -396,12 +396,6 @@ Lint/UnusedBlockArgument:
 Lint/UnusedMethodArgument:
   Enabled: false
 
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
-Lint/UselessAccessModifier:
-  Exclude:
-    - 'test/functional/repositories_git_controller_test.rb'
-
 Lint/UselessAssignment:
   Enabled: false
 
index 0ffd3134c4ff8509e9a6caeced5c67f1326c4857..01f745de666ac1191fdd8fab6e57108e6778b46b 100644 (file)
@@ -810,14 +810,6 @@ class RepositoriesGitControllerTest < Redmine::RepositoryControllerTest
       @project.reload
       assert_nil @project.repository
     end
-
-    private
-
-    def puts_pass_on_not_utf8
-      puts "TODO: This test fails " +
-           "when Encoding.default_external is not UTF-8. " +
-           "Current value is '#{Encoding.default_external.to_s}'"
-    end
   else
     puts "Git test repository NOT FOUND. Skipping functional tests !!!"
     def test_fake; assert true end
@@ -831,4 +823,10 @@ class RepositoriesGitControllerTest < Redmine::RepositoryControllerTest
     yield
     ActionController::Base.perform_caching = before
   end
+
+  def puts_pass_on_not_utf8
+    puts "TODO: This test fails " +
+         "when Encoding.default_external is not UTF-8. " +
+         "Current value is '#{Encoding.default_external.to_s}'"
+  end
 end