]> source.dussan.org Git - gitea.git/commitdiff
Add null check for responseData.invalidTopics (#32212)
authorcloudchamb3r <jizon0123@protonmail.com>
Tue, 8 Oct 2024 17:27:05 +0000 (02:27 +0900)
committerGitHub <noreply@github.com>
Tue, 8 Oct 2024 17:27:05 +0000 (01:27 +0800)
<img width="553" alt="Screenshot 2024-10-08 at 10 49 10 AM"
src="https://github.com/user-attachments/assets/faeef64d-684a-4aba-b7fc-c7c6a0301abe">

`responseData.invalidTopics` can be null but it wasn't handled.

web_src/js/features/repo-home.ts

index f3e39ddb3c1ae5105b084dab8524debb76a90a48..ed1415d286a8d62b403ac6e4c255cbc727d6df66 100644 (file)
@@ -60,7 +60,7 @@ export function initRepoTopicBar() {
       // how to test: input topic like " invalid topic " (with spaces), and select it from the list, then "Save"
       const responseData = await response.json();
       lastErrorToast = showErrorToast(responseData.message, {duration: 5000});
-      if (responseData.invalidTopics.length > 0) {
+      if (responseData.invalidTopics && responseData.invalidTopics.length > 0) {
         const {invalidTopics} = responseData;
         const topicLabels = queryElemChildren(topicDropdown, 'a.ui.label');
         for (const [index, value] of topics.split(',').entries()) {