]> source.dussan.org Git - redmine.git/commitdiff
Use uri_with_link_safe_scheme? in Redcloth3 (#38807).
authorGo MAEDA <maeda@farend.jp>
Mon, 18 Sep 2023 07:55:40 +0000 (07:55 +0000)
committerGo MAEDA <maeda@farend.jp>
Mon, 18 Sep 2023 07:55:40 +0000 (07:55 +0000)
Patch by Holger Just.

git-svn-id: https://svn.redmine.org/redmine/trunk@22303 e93f8b46-1217-0410-a6f0-8f06a7374b81

lib/redmine/wiki_formatting/textile/redcloth3.rb

index a2b53997fcabee148fde5c6a892b62a39c9fb47a..e319d90dbe5af526b8e663425df5c887b698bfbe 100644 (file)
@@ -841,7 +841,7 @@ class RedCloth3 < String
             end
 
             url = htmlesc(url.dup)
-            next all if url.downcase.start_with?('javascript:')
+            next all unless uri_with_link_safe_scheme?(url)
 
             atts = pba(atts)
             atts = +" href=\"#{url}#{slash}\"#{atts}"
@@ -965,7 +965,7 @@ class RedCloth3 < String
             next m unless uri_with_safe_scheme?(url.partition('?').first)
             if href
               href = htmlesc(href.dup)
-              next m if href.downcase.start_with?('javascript:')
+              next m unless uri_with_link_safe_scheme?(href)
             end
 
             out = +''