Maintain returning 0px from width/height for disconnected nodes for backwards compat...

diff --git a/src/css.js b/src/css.js
index 4665fa7cbbe671b8c34fca4143fe21aa2971f5b8..369485e4768e54cd7dcc28148d7c19e11d64aad9 100644 (file)
--- a/src/css.js
+++ b/src/css.js
@@ -177,13 +177,18 @@ jQuery.each(["height", "width"], function( i, name ) {
                                        }
 
                                        if ( val != null ) {
-                                               return val === "" ? "auto" : val;
+                                               // Should return "auto" instead of 0, use 0 for
+                                               // temporary backwards-compat
+                                               return val === "" ? "0px" : val;
                                        }
                                }
 
                                if ( val < 0 || val == null ) {
                                        val = elem.style[ name ];
-                                       return val === "" ? "auto" : val;
+
+                                       // Should return "auto" instead of 0, use 0 for
+                                       // temporary backwards-compat
+                                       return val === "" ? "0px" : val;
                                }
 
                                return typeof val === "string" ? val : val + "px";

diff --git a/test/unit/css.js b/test/unit/css.js
index 71f883508da133e709086afa859db286b85a21b1..cddd90256ec74d4bc051955d8bb1f41e48395dd1 100644 (file)
--- a/test/unit/css.js
+++ b/test/unit/css.js
@@ -13,8 +13,10 @@ test("css(String|Hash)", function() {
 
        var div = jQuery( "<div>" );
 
-       equals( div.css("width"), "auto", "Width on disconnected node." );
-       equals( div.css("height"), "auto", "Height on disconnected node." );
+       // These should be "auto" (or some better value)
+       // temporarily provide "0px" for backwards compat
+       equals( div.css("width"), "0px", "Width on disconnected node." );
+       equals( div.css("height"), "0px", "Height on disconnected node." );
 
        div.css({ width: 4, height: 4 });
 

diff --git a/test/unit/dimensions.js b/test/unit/dimensions.js
index 92cf17b7d876c4cdc80660c135259fea46a76931..8255bf325095aacbc3dddce2a62bc67b28d5a762 100644 (file)
--- a/test/unit/dimensions.js
+++ b/test/unit/dimensions.js
@@ -103,7 +103,7 @@ test("height() with function args", function() {
 });
 
 test("innerWidth()", function() {
-       expect(3);
+       expect(4);
 
        var $div = jQuery("#nothiddendiv");
        // set styles
@@ -121,10 +121,15 @@ test("innerWidth()", function() {
        
        // reset styles
        $div.css({ display: "", border: "", padding: "", width: "", height: "" });
+
+       var div = jQuery( "<div>" );
+
+       // Temporarily require 0 for backwards compat - should be auto
+       equals( div.innerWidth(), 0, "Make sure that disconnected nodes are handled." );
 });
 
 test("innerHeight()", function() {
-       expect(3);
+       expect(4);
        
        var $div = jQuery("#nothiddendiv");
        // set styles
@@ -142,10 +147,15 @@ test("innerHeight()", function() {
        
        // reset styles
        $div.css({ display: "", border: "", padding: "", width: "", height: "" });
+
+       var div = jQuery( "<div>" );
+
+       // Temporarily require 0 for backwards compat - should be auto
+       equals( div.innerHeight(), 0, "Make sure that disconnected nodes are handled." );
 });
 
 test("outerWidth()", function() {
-       expect(6);
+       expect(7);
        
        var $div = jQuery("#nothiddendiv");
        $div.css("width", 30);
@@ -164,10 +174,15 @@ test("outerWidth()", function() {
        
        // reset styles
        $div.css({ position: "", display: "", border: "", padding: "", width: "", height: "" });
+
+       var div = jQuery( "<div>" );
+
+       // Temporarily require 0 for backwards compat - should be auto
+       equals( div.outerWidth(), 0, "Make sure that disconnected nodes are handled." );
 });
 
 test("outerHeight()", function() {
-       expect(6);
+       expect(7);
        
        var $div = jQuery("#nothiddendiv");
        $div.css("height", 30);
@@ -185,4 +200,9 @@ test("outerHeight()", function() {
        
        // reset styles
        $div.css({ display: "", border: "", padding: "", width: "", height: "" });
+
+       var div = jQuery( "<div>" );
+
+       // Temporarily require 0 for backwards compat - should be auto
+       equals( div.outerHeight(), 0, "Make sure that disconnected nodes are handled." );
 });