SONAR-10052 fix Quality flaws

diff --git a/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/BuiltInQProfileInsert.java b/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/BuiltInQProfileInsert.java
index e079e6b279eae9798ffdda3c221641353dfbe348..4b1d18be22c2e92db432e3847332cfaaba94fd16 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/BuiltInQProfileInsert.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/BuiltInQProfileInsert.java
@@ -23,8 +23,8 @@ import org.sonar.db.DbSession;
 
 public interface BuiltInQProfileInsert {
   /**
-   * Persist a built-in profile and associate it to all existing organizations.
-   * Db sessions are committed.
+   * Persist a new built-in profile and associate it to all existing organizations.
+   * Db sessions are committed and Elasticsearch indices are updated..
    */
   void create(DbSession session, DbSession batchSession, BuiltInQProfile builtInQProfile);
 }

diff --git a/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/BuiltInQProfileUpdate.java b/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/BuiltInQProfileUpdate.java
index c4f90ca9dcb214fcc51c2f0d5dbb51a75c4ab40b..c1c1ecca07fb8bbe2f5dbc66cbabf5afd51aed96 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/BuiltInQProfileUpdate.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/BuiltInQProfileUpdate.java
@@ -25,8 +25,8 @@ import org.sonar.db.qualityprofile.RulesProfileDto;
 
 public interface BuiltInQProfileUpdate {
   /**
-   * Persist a built-in profile and associate it to all existing organizations.
-   * Db sessions are committed.
+   * Persist an existing built-in profile and associate it to all existing organizations.
+   * Db session is committed and Elasticsearch indices are updated.
    */
   List<ActiveRuleChange> update(DbSession dbSession, BuiltInQProfile builtInQProfile, RulesProfileDto ruleProfile);
 }

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/server/profile/BuiltInQualityProfilesDefinition.java b/sonar-plugin-api/src/main/java/org/sonar/api/server/profile/BuiltInQualityProfilesDefinition.java
index aed7a8578c0ba30a0ff9b5508d577ce26b3fd276..8908f09f177ff7c2d52ae4271bc2f78589f907fb 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/server/profile/BuiltInQualityProfilesDefinition.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/server/profile/BuiltInQualityProfilesDefinition.java
@@ -34,8 +34,6 @@ import org.sonar.api.ExtensionPoint;
 import org.sonar.api.rule.RuleKey;
 import org.sonar.api.rule.Severity;
 import org.sonar.api.server.ServerSide;
-import org.sonar.api.utils.log.Logger;
-import org.sonar.api.utils.log.Loggers;
 
 import static com.google.common.base.Preconditions.checkArgument;
 import static java.lang.String.format;
@@ -197,7 +195,6 @@ public interface BuiltInQualityProfilesDefinition {
   @Immutable
   class BuiltInQualityProfileImpl implements BuiltInQualityProfile {
 
-    private static final Logger LOG = Loggers.get(BuiltInQualityProfilesDefinition.BuiltInQualityProfileImpl.class);
     private final String language;
     private final String name;
     private final boolean isDefault;