]> source.dussan.org Git - nextcloud-server.git/commitdiff
fix: return type doc block added as per psalm
authoryemkareems <yemkareems@gmail.com>
Thu, 4 Jul 2024 13:48:16 +0000 (19:18 +0530)
committeryemkareems <yemkareems@gmail.com>
Mon, 8 Jul 2024 10:12:55 +0000 (15:42 +0530)
Signed-off-by: yemkareems <yemkareems@gmail.com>
lib/private/AllConfig.php
lib/public/IConfig.php

index 6b93fc9f6377bc3fddf0c8eb03c3b4cdd2f35306..c2fff700e10f3db52498c84f41dfce4f95f202ed 100644 (file)
@@ -497,7 +497,7 @@ class AllConfig implements IConfig {
         * @param int|null $limit how many users to fetch
         * @param int $offset from which offset to fetch
         * @param string $search search users based on search params
-        * @return array<string, string> list of user IDs
+        * @return list<string> list of user IDs
         */
        public function getLastLoggedInUsers(?int $limit = null, int $offset = 0, string $search = ''): array {
                // TODO - FIXME
@@ -513,15 +513,15 @@ class AllConfig implements IConfig {
                        );
                if($search !== '') {
                        $query->leftJoin('u', 'preferences', 'p1', $query->expr()->andX(
-                                       $query->expr()->eq('p1.userid', 'uid'),
-                                       $query->expr()->eq('p1.appid', $query->expr()->literal('settings')),
-                                       $query->expr()->eq('p1.configkey', $query->expr()->literal('email')))
-                               )
+                               $query->expr()->eq('p1.userid', 'uid'),
+                               $query->expr()->eq('p1.appid', $query->expr()->literal('settings')),
+                               $query->expr()->eq('p1.configkey', $query->expr()->literal('email')))
+                       )
                                // sqlite doesn't like re-using a single named parameter here
                                ->where($query->expr()->iLike('uid', $query->createPositionalParameter('%' . $this->connection->escapeLikeParameter($search) . '%')))
                                ->orWhere($query->expr()->iLike('displayname', $query->createPositionalParameter('%' . $this->connection->escapeLikeParameter($search) . '%')))
                                ->orWhere($query->expr()->iLike('p1.configvalue', $query->createPositionalParameter('%' . $this->connection->escapeLikeParameter($search) . '%'))
-                       );
+                               );
                }
                $query->orderBy($query->func()->lower('p.configvalue'), 'DESC')
                        ->addOrderBy('uid_lower', 'ASC')
@@ -529,6 +529,7 @@ class AllConfig implements IConfig {
                        ->setMaxResults($limit);
 
                $result = $query->executeQuery();
+               /** @var list<string> $uids */
                $uids = $result->fetchAll(\PDO::FETCH_COLUMN);
                $result->closeCursor();
 
index 01d513fc2b1953d980ccd8b76663022922f3888d..175f0e90c49169eddf313d9a221b7f700e46ade5 100644 (file)
@@ -256,7 +256,7 @@ interface IConfig {
         * @param int|null $limit how many records to fetch
         * @param int $offset from which offset to fetch
         * @param string $search search users based on search params
-        * @return array<string, string> list of user IDs
+        * @return list<string> list of user IDs
         * @since 30.0.0
         */
        public function getLastLoggedInUsers(?int $limit = null, int $offset = 0, string $search = ''): array;