]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-5851 apply feedback
authorStas Vilchik <vilchiks@gmail.com>
Tue, 5 May 2015 08:36:09 +0000 (10:36 +0200)
committerStas Vilchik <vilchiks@gmail.com>
Tue, 5 May 2015 08:36:09 +0000 (10:36 +0200)
server/sonar-web/src/main/js/quality-profiles/controller.js
server/sonar-web/src/main/js/quality-profiles/restore-built-in-profiles-view.js
server/sonar-web/src/test/js/quality-profiles.js

index 87c481b443679c33d828493513764994b4c5210e..b3fabdd04d0a44210a19442899ba111d12bbae8c 100644 (file)
@@ -111,6 +111,7 @@ define([
       this.options.app.router.navigate('');
       this.options.app.layout.headerRegion.reset();
       this.options.app.layout.detailsRegion.reset();
+      this.options.app.profilesView.highlight(null);
     },
 
     fetchProfiles: function () {
index 4285a6bf8d318af27cda4c82e44975a384c022d4..3d86785c57928f4a8ba1aad31962937e65b0c0f4 100644 (file)
@@ -57,6 +57,7 @@ define([
         }
       }).done(function () {
         that.collection.fetch({ reset: true });
+        that.collection.trigger('destroy');
         that.close();
       }).fail(function (jqXHR) {
         that.showErrors(jqXHR.responseJSON.errors, jqXHR.responseJSON.warnings);
index 50042e42ce2572e89f771699598c1d713d0e388f..56aa831f7513564d8761e1bfc8efe451cf56e954 100644 (file)
@@ -815,7 +815,7 @@ casper.test.begin(testName('Importers'), 6, function (test) {
 });
 
 
-casper.test.begin(testName('Restore Built-in Profiles'), 2, function (test) {
+casper.test.begin(testName('Restore Built-in Profiles'), 3, function (test) {
   casper
       .start(lib.buildUrl('profiles'), function () {
         lib.setDefaultViewport();
@@ -861,6 +861,7 @@ casper.test.begin(testName('Restore Built-in Profiles'), 2, function (test) {
 
       .then(function () {
         test.assertSelectorContains('.js-list .list-group-item', 'Sonar way');
+        test.assertDoesntExist('.search-navigator-header-component');
       })
 
       .then(function () {