Fix quality flaws

diff --git a/sonar-core/src/main/java/org/sonar/core/i18n/WorkDurationFormatter.java b/sonar-core/src/main/java/org/sonar/core/i18n/WorkDurationFormatter.java
index 93d652c2757d1291a6406b5f6c8dd96bf1c4e0ec..f760bf44802d380bd186011e2aa9ac172f511716 100644 (file)
--- a/sonar-core/src/main/java/org/sonar/core/i18n/WorkDurationFormatter.java
+++ b/sonar-core/src/main/java/org/sonar/core/i18n/WorkDurationFormatter.java
@@ -56,17 +56,25 @@ public class WorkDurationFormatter implements ServerComponent, BatchExtension {
     if (workDuration.days() > 0) {
       results.add(message("work_duration.x_days", isNegative ? -1 * workDuration.days() : workDuration.days()));
     }
-    if (workDuration.hours() > 0 && workDuration.days() < 10) {
+    if (displayHours(workDuration)) {
       addSpaceIfNeeded(results);
       results.add(message("work_duration.x_hours", isNegative && results.isEmpty() ? -1 * workDuration.hours() : workDuration.hours()));
     }
-    if (workDuration.minutes() > 0 && workDuration.hours() < 10 && workDuration.days() == 0) {
+    if (displayMinutes(workDuration)) {
       addSpaceIfNeeded(results);
       results.add(message("work_duration.x_minutes", isNegative && results.isEmpty() ? -1 * workDuration.minutes() : workDuration.minutes()));
     }
     return results;
   }
 
+  private boolean displayHours(WorkDuration workDuration){
+    return workDuration.hours() > 0 && workDuration.days() < 10;
+  }
+
+  private boolean displayMinutes(WorkDuration workDuration){
+    return workDuration.minutes() > 0 && workDuration.hours() < 10 && workDuration.days() == 0;
+  }
+
   private void addSpaceIfNeeded(List<Result> results){
     if (!results.isEmpty()) {
       results.add(new Result(" ", null));