Be specific about Firefox nodes-as-nodelist. Never assume that modern browsers will...

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>

diff --git a/src/core.js b/src/core.js
index 9832daa595320fdd5641e9db990805e551ef2886..5db9b5e829199f947ed88ff8d647adbbfb0a3ab4 100644 (file)
--- a/src/core.js
+++ b/src/core.js
@@ -919,6 +919,10 @@ function isArraylike( obj ) {
                return false;
        }
 
+       if ( obj.nodeType === 1 && length ) {
+               return true;
+       }
+
        return type === "array" || type !== "function" &&
                ( length === 0 ||
                typeof length === "number" && length > 0 && ( length - 1 ) in obj );

diff --git a/test/unit/core.js b/test/unit/core.js
index ba68afa7597ce377ebeab842329e83f09b00c1d2..ee0fd0bb2862cddda400651d13e96431b228104e 100644 (file)
--- a/test/unit/core.js
+++ b/test/unit/core.js
@@ -1141,7 +1141,9 @@ test("jQuery.makeArray", function(){
 
        equal( jQuery.makeArray(/a/)[0].constructor, RegExp, "Pass makeArray a regex" );
 
-       ok( jQuery.makeArray(document.getElementById("form")).length >= 13, "Pass makeArray a form (treat as elements)" );
+       // Some nodes inherit traits of nodelists
+       ok( jQuery.makeArray(document.getElementById("form")).length >= 13,
+               "Pass makeArray a form (treat as elements)" );
 });
 
 test("jQuery.inArray", function(){