]> source.dussan.org Git - aspectj.git/commitdiff
done!
authoraclement <aclement>
Sun, 8 Nov 2009 23:05:38 +0000 (23:05 +0000)
committeraclement <aclement>
Sun, 8 Nov 2009 23:05:38 +0000 (23:05 +0000)
org.aspectj.matcher/src/org/aspectj/weaver/ResolvedType.java

index 9494aa4454922e3c1e0400ecc3f4705c9d37157f..d89de7197270a22e83c94dc5e56b021b14f4e580 100644 (file)
@@ -590,7 +590,7 @@ public abstract class ResolvedType extends UnresolvedType implements AnnotatedEl
                return null;
        }
 
-       // DO ALL CALLERS DO THEIR OWN SEARCHING FOR ITDs?
+       // Bug (1) Do callers expect ITDs to be involved in the lookup? or do they do their own walk over ITDs?
        /**
         * Looks for the first member in the hierarchy matching aMember. This method differs from lookupMember(Member) in that it takes
         * into account parameters which are type variables - which clearly an unresolved Member cannot do since it does not know
@@ -613,7 +613,7 @@ public abstract class ResolvedType extends UnresolvedType implements AnnotatedEl
                                        candidate = candidate.getBackingGenericMember();
                                }
                        }
-
+                       // OPTIMIZE speed up matches? optimize order of checks
                        if (candidate.matches(aMember, eraseGenerics)) {
                                found = candidate;
                                break;
@@ -2186,6 +2186,7 @@ public abstract class ResolvedType extends UnresolvedType implements AnnotatedEl
 
                public ResolvedType next() {
                        ResolvedType next = delegate.next();
+                       // BUG should check for generics and erase?
                        if (!visited.contains(next)) {
                                visited.add(next);
                                toPersue.add(next); // pushes on interfaces already visited?
@@ -2197,7 +2198,7 @@ public abstract class ResolvedType extends UnresolvedType implements AnnotatedEl
                        throw new UnsupportedOperationException();
                }
        }
-
+       
        public void clearInterTypeMungers() {
                if (isRawType()) {
                        getGenericType().clearInterTypeMungers();