Fixed some normal priority warnings by FindBugs

svn changeset:13461/svn branch:6.3

diff --git a/tests/src/com/vaadin/tests/StressComponentsInTable.java b/tests/src/com/vaadin/tests/StressComponentsInTable.java
index 6f04f5b73178e7d066eb807c9a0b866d078f0b43..7e072eabd7f0eeb6f628ffd54f31d6e448c72f11 100644 (file)
--- a/tests/src/com/vaadin/tests/StressComponentsInTable.java
+++ b/tests/src/com/vaadin/tests/StressComponentsInTable.java
@@ -39,9 +39,9 @@ public class StressComponentsInTable extends CustomComponent {
 \r
                 public void buttonClick(ClickEvent event) {\r
                     Button b = event.getButton();\r
-                    System.out.println(event.getButton().getCaption()\r
-                            + " click: " + (new Date()).toGMTString());\r
-                    System.out.println(event.getButton().getApplication());\r
+                    System.out.println(b.getCaption() + " click: "\r
+                            + (new Date()).toGMTString());\r
+                    System.out.println(b.getApplication());\r
 \r
                 }\r
             }));\r

diff --git a/tests/src/com/vaadin/tests/book/TableEditable.java b/tests/src/com/vaadin/tests/book/TableEditable.java
index 0beefba320f61735993e5fc522394cfb3bfb007d..3e5dc0e6133a8bd23733547763aa640196dec1a9 100644 (file)
--- a/tests/src/com/vaadin/tests/book/TableEditable.java
+++ b/tests/src/com/vaadin/tests/book/TableEditable.java
@@ -36,9 +36,9 @@ public class TableEditable extends CustomComponent {
             calendar.add(Calendar.DAY_OF_YEAR, i);
 
             // Create the table row.
-            table.addItem(new Object[] { calendar.getTime(),
-                    new Boolean(false), "" }, new Integer(i)); // Item
-            // identifier
+            table.addItem(
+                    new Object[] { calendar.getTime(), Boolean.FALSE, "" },
+                    new Integer(i)); // Item identifier
         }
 
         table.setPageLength(8);

diff --git a/tests/src/com/vaadin/tests/components/button/Buttons.java b/tests/src/com/vaadin/tests/components/button/Buttons.java
index 0540a0dcde3bc32a94dc6b1883463ef1b670a659..1c5c35e237a7b777f46045843a3abefed6c7e049 100644 (file)
--- a/tests/src/com/vaadin/tests/components/button/Buttons.java
+++ b/tests/src/com/vaadin/tests/components/button/Buttons.java
@@ -100,9 +100,9 @@ public class Buttons extends ComponentTestCase<Button> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);

diff --git a/tests/src/com/vaadin/tests/components/combobox/Comboboxes.java b/tests/src/com/vaadin/tests/components/combobox/Comboboxes.java
index 39008f3db5a4de3289a886610ffe9010babdd937..40a70fa92abc33892b10c7fbb461b95a4f8d6a27 100644 (file)
--- a/tests/src/com/vaadin/tests/components/combobox/Comboboxes.java
+++ b/tests/src/com/vaadin/tests/components/combobox/Comboboxes.java
@@ -150,9 +150,9 @@ public class Comboboxes extends ComponentTestCase<ComboBox> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);

diff --git a/tests/src/com/vaadin/tests/components/label/LabelModes.java b/tests/src/com/vaadin/tests/components/label/LabelModes.java
index d7d426ec88927e56bbd4523d070c81a285923f3e..88ff296739ecd0677c9ff44958727c6101d0981b 100644 (file)
--- a/tests/src/com/vaadin/tests/components/label/LabelModes.java
+++ b/tests/src/com/vaadin/tests/components/label/LabelModes.java
@@ -91,9 +91,9 @@ public class LabelModes extends ComponentTestCase<Label> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);

diff --git a/tests/src/com/vaadin/tests/components/label/Labels.java b/tests/src/com/vaadin/tests/components/label/Labels.java
index 64c61ba13c96fc1a655d19c10ad83983cd0e1ba0..7bc7722b35bfa622c1ad5502add1c19780ff55ce 100644 (file)
--- a/tests/src/com/vaadin/tests/components/label/Labels.java
+++ b/tests/src/com/vaadin/tests/components/label/Labels.java
@@ -102,9 +102,9 @@ public class Labels extends ComponentTestCase<Label> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);

diff --git a/tests/src/com/vaadin/tests/components/menubar/Menubars.java b/tests/src/com/vaadin/tests/components/menubar/Menubars.java
index 04422251349f8cec4fc83053fef84076d48718ad..0c059b82db2f93b099827e5245c2e9f2a5b355d4 100644 (file)
--- a/tests/src/com/vaadin/tests/components/menubar/Menubars.java
+++ b/tests/src/com/vaadin/tests/components/menubar/Menubars.java
@@ -108,9 +108,9 @@ public class Menubars extends ComponentTestCase<MenuBar> {
                     }\r
                 });\r
 \r
-        errorIndicators.setValue(new Boolean(false));\r
-        readonly.setValue(new Boolean(false));\r
-        enabled.setValue(new Boolean(true));\r
+        errorIndicators.setValue(Boolean.FALSE);\r
+        readonly.setValue(Boolean.FALSE);\r
+        enabled.setValue(Boolean.TRUE);\r
 \r
         errorIndicators.setImmediate(true);\r
         readonly.setImmediate(true);\r

diff --git a/tests/src/com/vaadin/tests/components/richtextarea/RichTextAreas.java b/tests/src/com/vaadin/tests/components/richtextarea/RichTextAreas.java
index e3e12a1c8dd874a08fe1392544e3b43df86a46f0..71030d6b153d49d3ea15630539ae0be705f36270 100644 (file)
--- a/tests/src/com/vaadin/tests/components/richtextarea/RichTextAreas.java
+++ b/tests/src/com/vaadin/tests/components/richtextarea/RichTextAreas.java
@@ -96,10 +96,10 @@ public class RichTextAreas extends ComponentTestCase<RichTextArea> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        required.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        required.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         required.setImmediate(true);

diff --git a/tests/src/com/vaadin/tests/components/select/NativeSelects.java b/tests/src/com/vaadin/tests/components/select/NativeSelects.java
index cd2c95d127d89f5f9bae16e6553dd10faf4359e7..8f3b79af213f7a2d3c5fc5e2ca44edb5e7f7f05e 100644 (file)
--- a/tests/src/com/vaadin/tests/components/select/NativeSelects.java
+++ b/tests/src/com/vaadin/tests/components/select/NativeSelects.java
@@ -143,10 +143,10 @@ public class NativeSelects extends ComponentTestCase<NativeSelect> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
-        nullSelect.setValue(new Boolean(false));
+        errorIndicators.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
+        nullSelect.setValue(Boolean.FALSE);
 
         errorIndicators.setImmediate(true);
         readonly.setImmediate(true);

diff --git a/tests/src/com/vaadin/tests/components/textfield/TextFields.java b/tests/src/com/vaadin/tests/components/textfield/TextFields.java
index a908dccc1db06309e49c07def8fd0d17145c2b45..16ac819718487bfd47793d847d0f089d41906353 100644 (file)
--- a/tests/src/com/vaadin/tests/components/textfield/TextFields.java
+++ b/tests/src/com/vaadin/tests/components/textfield/TextFields.java
@@ -117,10 +117,10 @@ public class TextFields extends ComponentTestCase<TextField> {
                     }
                 });
 
-        errorIndicators.setValue(new Boolean(false));
-        required.setValue(new Boolean(false));
-        readonly.setValue(new Boolean(false));
-        enabled.setValue(new Boolean(true));
+        errorIndicators.setValue(Boolean.FALSE);
+        required.setValue(Boolean.FALSE);
+        readonly.setValue(Boolean.FALSE);
+        enabled.setValue(Boolean.TRUE);
 
         errorIndicators.setImmediate(true);
         required.setImmediate(true);

diff --git a/tests/src/com/vaadin/tests/featurebrowser/PropertyPanel.java b/tests/src/com/vaadin/tests/featurebrowser/PropertyPanel.java
index 5e105dbf1e492dde0ba3023fb978d439576b1bdf..6a87dec7489f8155c214b279dbb1747a3d673ad6 100644 (file)
--- a/tests/src/com/vaadin/tests/featurebrowser/PropertyPanel.java
+++ b/tests/src/com/vaadin/tests/featurebrowser/PropertyPanel.java
@@ -272,8 +272,8 @@ public class PropertyPanel extends Panel implements Button.ClickListener,
 
         // Customization for Window component
         if (objectToConfigure instanceof Window) {
-            disableField(set.getField("enabled"), new Boolean(true));
-            disableField(set.getField("visible"), new Boolean(true));
+            disableField(set.getField("enabled"), Boolean.TRUE);
+            disableField(set.getField("visible"), Boolean.TRUE);
             disableField(set.getField("componentError"));
             disableField(set.getField("icon"));
         }