[NO-JIRA] Fixing code smells

diff --git a/server/sonar-web/design-system/src/components/SizeIndicator.tsx b/server/sonar-web/design-system/src/components/SizeIndicator.tsx
index a5a4d54259b26d25d17f46c682bd77bf4ab6692c..3648223d0af505eed511fc660ffd65aa5ca224f5 100644 (file)
--- a/server/sonar-web/design-system/src/components/SizeIndicator.tsx
+++ b/server/sonar-web/design-system/src/components/SizeIndicator.tsx
@@ -34,15 +34,22 @@ const SIZE_MAPPING = {
   md: '2rem',
 };
 
+const SIZE_IN_LOC = {
+  xs: 1000,
+  sm: 10_000,
+  md: 100_000,
+  l: 500_000,
+};
+
 export function SizeIndicator({ size = 'sm', value }: Props) {
   let letter: SizeLabel;
-  if (inRange(value, 0, 1000)) {
+  if (inRange(value, 0, SIZE_IN_LOC.xs)) {
     letter = 'XS';
-  } else if (inRange(value, 1000, 10000)) {
+  } else if (inRange(value, SIZE_IN_LOC.xs, SIZE_IN_LOC.sm)) {
     letter = 'S';
-  } else if (inRange(value, 10000, 100000)) {
+  } else if (inRange(value, SIZE_IN_LOC.sm, SIZE_IN_LOC.md)) {
     letter = 'M';
-  } else if (inRange(value, 100000, 500000)) {
+  } else if (inRange(value, SIZE_IN_LOC.md, SIZE_IN_LOC.l)) {
     letter = 'L';
   } else {
     letter = 'XL';

diff --git a/server/sonar-web/src/main/js/apps/projectInformation/about/components/MetaTags.tsx b/server/sonar-web/src/main/js/apps/projectInformation/about/components/MetaTags.tsx
index 68ce51c2bc10a0fc7d316f7057ef6e2f26bd2c23..65a075d8e25e8676a271ea8b316122299fc4ddb6 100644 (file)
--- a/server/sonar-web/src/main/js/apps/projectInformation/about/components/MetaTags.tsx
+++ b/server/sonar-web/src/main/js/apps/projectInformation/about/components/MetaTags.tsx
@@ -37,7 +37,7 @@ export default function MetaTags(props: Props) {
 
   const canUpdateTags = () => {
     const { configuration } = props.component;
-    return configuration && configuration.showSettings;
+    return configuration?.showSettings;
   };
 
   const setTags = (values: string[]) => {
@@ -63,7 +63,7 @@ export default function MetaTags(props: Props) {
     );
   };
 
-  const tags = props.component.tags || [];
+  const tags = props.component.tags ?? [];
 
   return (
     <>
@@ -91,6 +91,7 @@ interface MetaTagsSelectorProps {
 }
 
 const LIST_SIZE = 10;
+const MAX_LIST_SIZE = 100;
 
 function MetaTagsSelector({ selectedTags, setProjectTags }: MetaTagsSelectorProps) {
   const [searchResult, setSearchResult] = useState<string[]>([]);
@@ -99,7 +100,7 @@ function MetaTagsSelector({ selectedTags, setProjectTags }: MetaTagsSelectorProp
   const onSearch = (query: string) => {
     return searchProjectTags({
       q: query,
-      ps: Math.min(selectedTags.length - 1 + LIST_SIZE, 100),
+      ps: Math.min(selectedTags.length - 1 + LIST_SIZE, MAX_LIST_SIZE),
     }).then(
       ({ tags }) => setSearchResult(tags),
       () => {}