Fix some quality flaws

diff --git a/sonar-batch/src/main/java/org/sonar/batch/report/TestExecutionAndCoveragePublisher.java b/sonar-batch/src/main/java/org/sonar/batch/report/TestExecutionAndCoveragePublisher.java
index 84358102b7862d11c96acb6f4248c2cdae3bdae8..9144de126bfda391c03e3d2070c55e4a2cb6ed72 100644 (file)
--- a/sonar-batch/src/main/java/org/sonar/batch/report/TestExecutionAndCoveragePublisher.java
+++ b/sonar-batch/src/main/java/org/sonar/batch/report/TestExecutionAndCoveragePublisher.java
@@ -41,7 +41,7 @@ import java.util.Set;
 
 public class TestExecutionAndCoveragePublisher implements ReportPublisherStep {
 
-  private final class TestConverter implements Function<MutableTestCase, BatchReport.Test> {
+  private static final class TestConverter implements Function<MutableTestCase, BatchReport.Test> {
     private final Set<String> testNamesWithCoverage;
     private BatchReport.Test.Builder builder = BatchReport.Test.newBuilder();
 

diff --git a/sonar-batch/src/main/java/org/sonar/batch/scan/report/RuleNameProvider.java b/sonar-batch/src/main/java/org/sonar/batch/scan/report/RuleNameProvider.java
index 80b3ea91fc8019ec4efcc57ae89113cc45840683..6828fca449d9471392b6bfd19ca6c5b905b76d47 100644 (file)
--- a/sonar-batch/src/main/java/org/sonar/batch/scan/report/RuleNameProvider.java
+++ b/sonar-batch/src/main/java/org/sonar/batch/scan/report/RuleNameProvider.java
@@ -47,7 +47,7 @@ public class RuleNameProvider implements BatchComponent {
 
   public String nameForJS(String ruleKey) {
     String name = nameFromDB(RuleKey.parse(ruleKey));
-    return StringEscapeUtils.escapeJavaScript(name != null ? name : ruleKey.toString());
+    return StringEscapeUtils.escapeJavaScript(name != null ? name : ruleKey);
   }
 
   public String nameForHTML(Rule rule) {