findbugs URF_UNREAD_FIELD: note that unread fields were commented out in r1748084...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748098 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidationHelper.java b/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidationHelper.java
index a6990f3e238c877c70f638defa1fe813434dbcbe..15161cb882d748e1a3e31a91bbf40b9b0dc09b89 100644 (file)
--- a/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidationHelper.java
+++ b/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidationHelper.java
@@ -27,11 +27,12 @@ import org.apache.poi.ss.util.CellRangeAddressList;
  * Helper for working with Data Validation
  */
 public class HSSFDataValidationHelper implements DataValidationHelper {
-       //URF_UNREAD_FIELD
+       // Findbugs: URF_UNREAD_FIELD . Do not delete without understanding how this class works.
        //private HSSFSheet sheet;
        
        public HSSFDataValidationHelper(HSSFSheet sheet) {
                super();
+               // Findbugs: URF_UNREAD_FIELD . Do not delete without understanding how this class works.
                //this.sheet = sheet;
        }
 

diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFTextbox.java b/src/java/org/apache/poi/hssf/usermodel/HSSFTextbox.java
index 0dd4533e39f8774ed8f41b756e2714da694189a2..d1e8b9ffae2eddbeee206e8505925dc40da19562 100644 (file)
--- a/src/java/org/apache/poi/hssf/usermodel/HSSFTextbox.java
+++ b/src/java/org/apache/poi/hssf/usermodel/HSSFTextbox.java
@@ -48,7 +48,7 @@ public class HSSFTextbox extends HSSFSimpleShape {
         super(spContainer, objRecord, textObjectRecord);
     }
 
-    //Unused: URF_UNREAD_FIELD
+    // Findbugs: URF_UNREAD_FIELD. Do not delete without understanding how this class works.
     //HSSFRichTextString string = new HSSFRichTextString("");
 
     /**

diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationHelper.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationHelper.java
index 98b2a84d779eeaee48a7d4aa7013ec87d45f4490..8f7908dbd6e2ff7afbb0711e589ed5ac22b4de5f 100644 (file)
--- a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationHelper.java
+++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationHelper.java
@@ -35,12 +35,13 @@ import org.openxmlformats.schemas.spreadsheetml.x2006.main.STDataValidationType;
  *
  */
 public class XSSFDataValidationHelper implements DataValidationHelper {
-    //Unused: URF_UNREAD_FIELD
+       // Findbugs: URF_UNREAD_FIELD. Do not delete without understanding how this class works.
        //private XSSFSheet xssfSheet;
        
     
     public XSSFDataValidationHelper(XSSFSheet xssfSheet) {
                super();
+               // Findbugs: URF_UNREAD_FIELD. Do not delete without understanding how this class works.
                //this.xssfSheet = xssfSheet;
        }
 

diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java
index 4c0811f79a188bf23ea94418044001ecf8c4f53b..e0bbc266bce6c7ad94c07b097f1f6c44ece3b4d3 100644 (file)
--- a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java
+++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java
@@ -43,8 +43,8 @@ public final class XSSFGraphicFrame extends XSSFShape {
        private static CTGraphicalObjectFrame prototype = null;
 
        private CTGraphicalObjectFrame graphicFrame;
-       // Unused: URF_UNREAD_FIELD
-       //private XSSFDrawing drawing;
+       // FIXME: shadows protected XSSFShape.drawing
+       private XSSFDrawing drawing;
        private XSSFClientAnchor anchor;
 
        /**