[NO JIRA] Fixing bugs and code smells

diff --git a/server/sonar-web/src/main/js/apps/code/utils.ts b/server/sonar-web/src/main/js/apps/code/utils.ts
index c1363ecf84ea5bf0317ecc72aebbf8a26d48118a..73a5f70b74e7646c4a8244a4465d71934d27a642 100644 (file)
--- a/server/sonar-web/src/main/js/apps/code/utils.ts
+++ b/server/sonar-web/src/main/js/apps/code/utils.ts
@@ -27,9 +27,9 @@ import {
   addComponent,
   addComponentBreadcrumbs,
   addComponentChildren,
-  getComponent as getComponentFromBucket,
   getComponentBreadcrumbs,
   getComponentChildren,
+  getComponent as getComponentFromBucket,
 } from './bucket';
 
 const METRICS = [
@@ -287,7 +287,7 @@ export function loadMoreChildren(
 }
 
 export function mostCommonPrefix(strings: string[]) {
-  const sortedStrings = strings.slice(0).sort();
+  const sortedStrings = strings.slice(0).sort((a, b) => a.localeCompare(b));
   const firstString = sortedStrings[0];
   const firstStringLength = firstString.length;
   const lastString = sortedStrings[sortedStrings.length - 1];

diff --git a/server/sonar-web/src/main/js/components/issue/popups/CommentTile.tsx b/server/sonar-web/src/main/js/components/issue/popups/CommentTile.tsx
index c280798cf429a3a4b329a7d4db4edac82ade75f9..e6823b0f6a4bf35a75c36a71e9433748b1b3d993 100644 (file)
--- a/server/sonar-web/src/main/js/components/issue/popups/CommentTile.tsx
+++ b/server/sonar-web/src/main/js/components/issue/popups/CommentTile.tsx
@@ -59,7 +59,7 @@ export default class CommentTile extends React.PureComponent<CommentTileProps, C
   render() {
     const { comment } = this.props;
     const { showEditArea } = this.state;
-    const author = comment.authorName || comment.author;
+    const author = comment.authorName ?? comment.author;
     const displayName =
       comment.authorActive === false && author
         ? translateWithParameters('user.x_deleted', author)