Fix violations

diff --git a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/UnitTestDecorator.java b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/UnitTestDecorator.java
index 0658a9733abaa64a214551c5fff419c55e82f1b3..e0758ca0e36f998c0e948efd4a0d1d7eb8db2788 100644 (file)
--- a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/UnitTestDecorator.java
+++ b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/UnitTestDecorator.java
@@ -70,7 +70,7 @@ public class UnitTestDecorator implements Decorator {
 
   private Double sumChildren(DecoratorContext jobContext, Metric metric) {
     Collection<Measure> childrenMeasures = jobContext.getChildrenMeasures(metric);
-    if (childrenMeasures != null && childrenMeasures.size() > 0) {
+    if (childrenMeasures != null && !childrenMeasures.isEmpty()) {
       Double sum = 0.0;
       boolean hasChildrenMeasures = false;
       for (Measure measure : childrenMeasures) {

diff --git a/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgeOrphanResources.java b/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgeOrphanResources.java
index f3e6d62a8d13b19532dba6b43901b86077765e00..9178b5ad85db55eb5b8fa6530a1e94d4aace9637 100644 (file)
--- a/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgeOrphanResources.java
+++ b/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgeOrphanResources.java
@@ -42,7 +42,7 @@ public final class PurgeOrphanResources extends Purge {
     Query query = getSession().createQuery("SELECT r1.id FROM " + ResourceModel.class.getSimpleName() +
         " r1 WHERE r1.rootId IS NOT NULL AND NOT EXISTS(FROM " + ResourceModel.class.getSimpleName() + " r2 WHERE r1.rootId=r2.id)");
     List<Integer> idsToDelete = query.getResultList();
-    if (idsToDelete.size() > 0) {
+    if (!idsToDelete.isEmpty()) {
       PurgeUtils.executeQuery(getSession(), "", idsToDelete, "DELETE FROM " + ResourceModel.class.getSimpleName() + " WHERE id in (:ids)");
     }
   }

diff --git a/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgePropertyOrphans.java b/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgePropertyOrphans.java
index 74dda00b9a7b88848f58bc37f388166f7cd3ae24..cdc9c708f0526dd8562390e8e9096dabd9d11fd9 100644 (file)
--- a/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgePropertyOrphans.java
+++ b/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgePropertyOrphans.java
@@ -49,7 +49,7 @@ public final class PurgePropertyOrphans extends Purge {
     Query query = getSession().createQuery("SELECT p.id FROM " + Property.class.getSimpleName() +
         " p WHERE p.resourceId IS NOT NULL AND NOT EXISTS(FROM " + ResourceModel.class.getSimpleName() + " r WHERE r.id=p.resourceId)");
     List<Integer> idsToDelete = query.getResultList();
-    if (idsToDelete.size() > 0) {
+    if (!idsToDelete.isEmpty()) {
       PurgeUtils.executeQuery(getSession(), "", idsToDelete, "DELETE FROM " + Property.class.getSimpleName() + " WHERE id in (:ids)");
     }
   }
@@ -58,7 +58,7 @@ public final class PurgePropertyOrphans extends Purge {
     Query query = getSession().createQuery("SELECT p.id FROM " + Property.class.getSimpleName() +
         " p WHERE p.userId IS NOT NULL AND NOT EXISTS(FROM " + User.class.getSimpleName() + " u WHERE u.id=p.userId)");
     List<Integer> idsToDelete = query.getResultList();
-    if (idsToDelete.size() > 0) {
+    if (!idsToDelete.isEmpty()) {
       PurgeUtils.executeQuery(getSession(), "", idsToDelete, "DELETE FROM " + Property.class.getSimpleName() + " WHERE id in (:ids)");
     }
   }

diff --git a/sonar-server/src/main/java/org/sonar/server/filters/Filter.java b/sonar-server/src/main/java/org/sonar/server/filters/Filter.java
index 070c360c94db4051081638e903768e5d6f007baf..77dcb54b9ff240e53ee90caed3b4e209dd0b37af 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/filters/Filter.java
+++ b/sonar-server/src/main/java/org/sonar/server/filters/Filter.java
@@ -121,7 +121,7 @@ public class Filter {
   }
 
   public boolean hasQualifiers() {
-    return qualifiers != null && qualifiers.size() > 0;
+    return qualifiers != null && !qualifiers.isEmpty();
   }
 
   public Filter setQualifiers(Set<String> qualifiers) {

diff --git a/sonar-server/src/main/java/org/sonar/server/ui/DefaultPages.java b/sonar-server/src/main/java/org/sonar/server/ui/DefaultPages.java
index cd02ce58e5f7461d2b5d251862cdfcdf6ea7bbeb..59f1219ba17b5033bc7c37662d3313e9d394274f 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/ui/DefaultPages.java
+++ b/sonar-server/src/main/java/org/sonar/server/ui/DefaultPages.java
@@ -31,7 +31,7 @@ public final class DefaultPages {
   private static final View[] PAGES = {new SourceTab(), new CoverageTab(), new ViolationsTab()};
 
   public static View[] getPages() {
-    return PAGES;
+    return PAGES.clone();
   }
 
   // should be qualifier FILE only but waiting for java refactoring