]> source.dussan.org Git - poi.git/commitdiff
show full exception stack-trace if zip-bomb detection test fails
authorDominik Stadler <centic@apache.org>
Wed, 24 Jun 2015 08:33:06 +0000 (08:33 +0000)
committerDominik Stadler <centic@apache.org>
Wed, 24 Jun 2015 08:33:06 +0000 (08:33 +0000)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687197 13f79535-47bb-0310-9956-ffa450edef68

src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java

index 01c1b7707d32bcfe9d055c9164785f129f23539c..2383455fce1fd10c841c75d4c6d1933ffdf6b3a1 100644 (file)
@@ -712,7 +712,7 @@ public final class TestPackage {
             Workbook wb = WorkbookFactory.create(file);
             wb.close();
     
-            // check ratio ouf of bounds
+            // check ratio out of bounds
             ZipSecureFile.setMinInflateRatio(min_ratio+0.002);
             try {
                 wb = WorkbookFactory.create(file);
@@ -721,11 +721,15 @@ public final class TestPackage {
                 // depending if this executed via "ant test" or within eclipse
                 // maybe a difference in JDK ...
             } catch (InvalidFormatException e) {
-                assertEquals("Zip bomb detected! Exiting.", e.getMessage());
+                if(!e.getMessage().equals("Zip bomb detected! Exiting.")) {
+                    throw new IllegalStateException(e);
+                }
             } catch (POIXMLException e) {
                 InvocationTargetException t = (InvocationTargetException)e.getCause();
                 IOException t2 = (IOException)t.getTargetException();
-                assertEquals("Zip bomb detected! Exiting.", t2.getMessage());
+                if(!t2.getMessage().equals("Zip bomb detected! Exiting.")) {
+                    throw new IllegalStateException(e);
+                }
             }
     
             // check max entry size ouf of bounds
@@ -735,11 +739,15 @@ public final class TestPackage {
                 wb = WorkbookFactory.create(file, null, true);
                 wb.close();
             } catch (InvalidFormatException e) {
-                assertEquals("Zip bomb detected! Exiting.", e.getMessage());
+                if(!e.getMessage().equals("Zip bomb detected! Exiting.")) {
+                    throw new IllegalStateException(e);
+                }
             } catch (POIXMLException e) {
                 InvocationTargetException t = (InvocationTargetException)e.getCause();
                 IOException t2 = (IOException)t.getTargetException();
-                assertEquals("Zip bomb detected! Exiting.", t2.getMessage());
+                if(!t2.getMessage().equals("Zip bomb detected! Exiting.")) {
+                    throw new IllegalStateException(e);
+                }
             }
         } finally {
             // reset otherwise a lot of ooxml tests will fail