Remove unused parameter for some functions in `services/mirror` (#30724)

Suggested by gopls `unusedparams`

diff --git a/services/mirror/mirror.go b/services/mirror/mirror.go
index 72e545581a13145b93031e0e2da74a78ce55ffec..0270f870390dc80f67f2983d834c106f9f33b4af 100644 (file)
--- a/services/mirror/mirror.go
+++ b/services/mirror/mirror.go
@@ -40,7 +40,7 @@ func Update(ctx context.Context, pullLimit, pushLimit int) error {
        }
        log.Trace("Doing: Update")
 
-       handler := func(idx int, bean any) error {
+       handler := func(bean any) error {
                var repo *repo_model.Repository
                var mirrorType SyncType
                var referenceID int64
@@ -91,7 +91,7 @@ func Update(ctx context.Context, pullLimit, pushLimit int) error {
        pullMirrorsRequested := 0
        if pullLimit != 0 {
                if err := repo_model.MirrorsIterate(ctx, pullLimit, func(idx int, bean any) error {
-                       if err := handler(idx, bean); err != nil {
+                       if err := handler(bean); err != nil {
                                return err
                        }
                        pullMirrorsRequested++
@@ -105,7 +105,7 @@ func Update(ctx context.Context, pullLimit, pushLimit int) error {
        pushMirrorsRequested := 0
        if pushLimit != 0 {
                if err := repo_model.PushMirrorsIterate(ctx, pushLimit, func(idx int, bean any) error {
-                       if err := handler(idx, bean); err != nil {
+                       if err := handler(bean); err != nil {
                                return err
                        }
                        pushMirrorsRequested++

diff --git a/services/mirror/mirror_pull.go b/services/mirror/mirror_pull.go
index f5eaeaf091de1388eb56ffc9d426998a84517fd3..9f7ffb29c9f36be06ee0c7c21f3b9f40584180fa 100644 (file)
--- a/services/mirror/mirror_pull.go
+++ b/services/mirror/mirror_pull.go
@@ -466,7 +466,7 @@ func SyncPullMirror(ctx context.Context, repoID int64) bool {
 
        log.Trace("SyncMirrors [repo: %-v]: %d branches updated", m.Repo, len(results))
        if len(results) > 0 {
-               if ok := checkAndUpdateEmptyRepository(ctx, m, gitRepo, results); !ok {
+               if ok := checkAndUpdateEmptyRepository(ctx, m, results); !ok {
                        log.Error("SyncMirrors [repo: %-v]: checkAndUpdateEmptyRepository: %v", m.Repo, err)
                        return false
                }
@@ -564,7 +564,7 @@ func SyncPullMirror(ctx context.Context, repoID int64) bool {
        return true
 }
 
-func checkAndUpdateEmptyRepository(ctx context.Context, m *repo_model.Mirror, gitRepo *git.Repository, results []*mirrorSyncResult) bool {
+func checkAndUpdateEmptyRepository(ctx context.Context, m *repo_model.Mirror, results []*mirrorSyncResult) bool {
        if !m.Repo.IsEmpty {
                return true
        }