]> source.dussan.org Git - rspamd.git/commitdiff
[Minor] Final stage of g_slice removal
authorVsevolod Stakhov <vsevolod@highsecure.ru>
Sun, 29 Oct 2017 12:25:45 +0000 (12:25 +0000)
committerVsevolod Stakhov <vsevolod@highsecure.ru>
Sun, 29 Oct 2017 12:25:45 +0000 (12:25 +0000)
src/client/rspamc.c
src/client/rspamdclient.c
src/libstat/backends/mmaped_file.c
src/libstat/backends/sqlite3_backend.c
src/libstat/learn_cache/redis_cache.c
src/libstat/learn_cache/sqlite3_cache.c
src/libutil/fstring.h
src/rspamadm/confighelp.c
src/rspamadm/fuzzy_merge.c
src/rspamadm/lua_repl.c

index 08c23a1b8f9f4f891f6b82dbbcbaa231e4848967..bf13acc686110fd7e989a72eb73478391bbf80fe 100644 (file)
@@ -1572,7 +1572,7 @@ rspamc_client_cb (struct rspamd_client_connection *conn,
 
        rspamd_client_destroy (conn);
        g_free (cbdata->filename);
-       g_slice_free1 (sizeof (struct rspamc_callback_data), cbdata);
+       g_free (cbdata);
 }
 
 static void
@@ -1623,7 +1623,7 @@ rspamc_process_input (struct event_base *ev_base, struct rspamc_command *cmd,
        conn = rspamd_client_init (ev_base, hostbuf, port, timeout, key);
 
        if (conn != NULL) {
-               cbdata = g_slice_alloc (sizeof (struct rspamc_callback_data));
+               cbdata = g_malloc0 (sizeof (struct rspamc_callback_data));
                cbdata->cmd = cmd;
                cbdata->filename = g_strdup (name);
 
index 4a58b3628ef3de63f7e9072810b45fb9c425b566..ad801c182f57e82741176f4c4ad0a8d07dd7b816 100644 (file)
@@ -73,7 +73,7 @@ rspamd_client_request_free (struct rspamd_client_request *req)
                        g_string_free (req->input, TRUE);
                }
 
-               g_slice_free1 (sizeof (*req), req);
+               g_free (req);
        }
 }
 
@@ -252,7 +252,7 @@ rspamd_client_init (struct event_base *ev_base, const gchar *name,
                return NULL;
        }
 
-       conn = g_slice_alloc0 (sizeof (struct rspamd_client_connection));
+       conn = g_malloc0 (sizeof (struct rspamd_client_connection));
        conn->ev_base = ev_base;
        conn->fd = fd;
        conn->req_sent = FALSE;
@@ -310,7 +310,7 @@ rspamd_client_command (struct rspamd_client_connection *conn,
        void *dict = NULL;
        ZSTD_CCtx *zctx;
 
-       req = g_slice_alloc0 (sizeof (struct rspamd_client_request));
+       req = g_malloc0 (sizeof (struct rspamd_client_request));
        req->conn = conn;
        req->cb = cb;
        req->ud = ud;
@@ -342,7 +342,7 @@ rspamd_client_command (struct rspamd_client_connection *conn,
                if (ferror (in) != 0) {
                        g_set_error (err, RCLIENT_ERROR, ferror (
                                        in), "input IO error: %s", strerror (ferror (in)));
-                       g_slice_free1 (sizeof (struct rspamd_client_request), req);
+                       g_free (req);
                        g_string_free (input, TRUE);
                        return FALSE;
                }
@@ -360,7 +360,7 @@ rspamd_client_command (struct rspamd_client_connection *conn,
                                                        "cannot open dictionary %s: %s",
                                                        comp_dictionary,
                                                        strerror (errno));
-                                       g_slice_free1 (sizeof (struct rspamd_client_request), req);
+                                       g_free (req);
                                        g_string_free (input, TRUE);
 
                                        return FALSE;
@@ -373,7 +373,7 @@ rspamd_client_command (struct rspamd_client_connection *conn,
                                                        "cannot open dictionary %s: %s",
                                                        comp_dictionary,
                                                        strerror (errno));
-                                       g_slice_free1 (sizeof (struct rspamd_client_request), req);
+                                       g_free (req);
                                        g_string_free (input, TRUE);
                                        munmap (dict, dict_len);
 
@@ -393,7 +393,7 @@ rspamd_client_command (struct rspamd_client_connection *conn,
                        if (ZSTD_isError (body->len)) {
                                g_set_error (err, RCLIENT_ERROR, ferror (
                                                in), "compression error");
-                               g_slice_free1 (sizeof (struct rspamd_client_request), req);
+                               g_free (req);
                                g_string_free (input, TRUE);
                                rspamd_fstring_free (body);
                                ZSTD_freeCCtx (zctx);
@@ -466,6 +466,6 @@ rspamd_client_destroy (struct rspamd_client_connection *conn)
                        rspamd_keypair_unref (conn->keypair);
                }
                g_string_free (conn->server_name, TRUE);
-               g_slice_free1 (sizeof (struct rspamd_client_connection), conn);
+               g_free (conn);
        }
 }
index 65ccb5aa1a5fbb688a988734f9b97f66e500f018..b3861ca965e406cda88cf23730e94fe1836aa2cf 100644 (file)
@@ -597,13 +597,13 @@ rspamd_mmaped_file_open (rspamd_mempool_t *pool,
                        size);
        }
 
-       new_file = g_slice_alloc0 (sizeof (rspamd_mmaped_file_t));
+       new_file = g_malloc0 (sizeof (rspamd_mmaped_file_t));
        if ((new_file->fd = open (filename, O_RDWR)) == -1) {
                msg_info_pool ("cannot open file %s, error %d, %s",
                        filename,
                        errno,
                        strerror (errno));
-               g_slice_free1 (sizeof (*new_file), new_file);
+               g_free (new_file);
                return NULL;
        }
 
@@ -615,7 +615,7 @@ rspamd_mmaped_file_open (rspamd_mempool_t *pool,
                        filename,
                        errno,
                        strerror (errno));
-               g_slice_free1 (sizeof (*new_file), new_file);
+               g_free (new_file);
                return NULL;
 
        }
@@ -632,7 +632,7 @@ rspamd_mmaped_file_open (rspamd_mempool_t *pool,
                                filename,
                                errno,
                                strerror (errno));
-               g_slice_free1 (sizeof (*new_file), new_file);
+               g_free (new_file);
                return NULL;
        }
 
@@ -640,7 +640,7 @@ rspamd_mmaped_file_open (rspamd_mempool_t *pool,
                close (new_file->fd);
                rspamd_file_unlock (new_file->fd, FALSE);
                munmap (new_file->map, st.st_size);
-               g_slice_free1 (sizeof (*new_file), new_file);
+               g_free (new_file);
                return NULL;
        }
 
@@ -669,7 +669,7 @@ rspamd_mmaped_file_close_file (rspamd_mempool_t *pool,
                close (file->fd);
        }
 
-       g_slice_free1 (sizeof (*file), file);
+       g_free (file);
 
        return 0;
 }
index ec47b06a922852c7c2aa2e105f12085bf3cd4194..6563d0dc18edee10ef9f53b2abd282bdf61212bb 100644 (file)
@@ -437,13 +437,13 @@ rspamd_sqlite3_opendb (rspamd_mempool_t *pool,
                        .tv_nsec = 1000000
        };
 
-       bk = g_slice_alloc0 (sizeof (*bk));
+       bk = g_malloc0 (sizeof (*bk));
        bk->sqlite = rspamd_sqlite3_open_or_create (pool, path, create_tables_sql,
                        0, err);
        bk->pool = pool;
 
        if (bk->sqlite == NULL) {
-               g_slice_free1 (sizeof (*bk), bk);
+               g_free (bk);
 
                return NULL;
        }
@@ -455,7 +455,7 @@ rspamd_sqlite3_opendb (rspamd_mempool_t *pool,
 
        if (bk->prstmt == NULL) {
                sqlite3_close (bk->sqlite);
-               g_slice_free1 (sizeof (*bk), bk);
+               g_free (bk);
 
                return NULL;
        }
@@ -472,7 +472,7 @@ rspamd_sqlite3_opendb (rspamd_mempool_t *pool,
                msg_err_pool ("failed to stard transaction: %d, %s", ret,
                                sqlite3_errmsg (bk->sqlite));
                sqlite3_close (bk->sqlite);
-               g_slice_free1 (sizeof (*bk), bk);
+               g_free (bk);
 
                return NULL;
        }
@@ -496,7 +496,7 @@ rspamd_sqlite3_opendb (rspamd_mempool_t *pool,
                                (gint64)strlen (tok_conf_encoded),
                                tok_conf_encoded) != SQLITE_OK) {
                        sqlite3_close (bk->sqlite);
-                       g_slice_free1 (sizeof (*bk), bk);
+                       g_free (bk);
                        g_free (tok_conf_encoded);
 
                        return NULL;
@@ -642,7 +642,7 @@ rspamd_sqlite3_close (gpointer p)
                rspamd_sqlite3_close_prstmt (bk->sqlite, bk->prstmt);
                sqlite3_close (bk->sqlite);
                g_free (bk->fname);
-               g_slice_free1 (sizeof (*bk), bk);
+               g_free (bk);
        }
 }
 
index 14a90b9d1b315fa13bfb149fa82b8ea380a318a7..b7ba71f4b1c54efb160a28f1e03af62c2bccdf38 100644 (file)
@@ -302,7 +302,7 @@ rspamd_stat_cache_redis_init (struct rspamd_stat_ctx *ctx,
        const ucl_object_t *obj;
        gboolean ret = FALSE;
 
-       cache_ctx = g_slice_alloc0 (sizeof (*cache_ctx));
+       cache_ctx = g_malloc0 (sizeof (*cache_ctx));
 
        /* First search in backend configuration */
        obj = ucl_object_lookup (st->classifier->cfg->opts, "backend");
@@ -344,7 +344,7 @@ rspamd_stat_cache_redis_init (struct rspamd_stat_ctx *ctx,
 
        if (!ret) {
                msg_err_config ("cannot init redis cache for %s", stf->symbol);
-               g_slice_free1 (sizeof (*cache_ctx), cache_ctx);
+               g_free (cache_ctx);
                return NULL;
        }
 
index 055950cf43092541d281025259a123fac8c14931..255c835bb50395f1022efd1cd92aa28c21e4c80a 100644 (file)
@@ -143,7 +143,7 @@ rspamd_stat_cache_sqlite3_init (struct rspamd_stat_ctx *ctx,
                err = NULL;
        }
        else {
-               new = g_slice_alloc (sizeof (*new));
+               new = g_malloc0 (sizeof (*new));
                new->db = sqlite;
                new->prstmt = rspamd_sqlite3_init_prstmt (sqlite, prepared_stmts,
                                RSPAMD_STAT_CACHE_MAX, &err);
@@ -153,7 +153,7 @@ rspamd_stat_cache_sqlite3_init (struct rspamd_stat_ctx *ctx,
                        g_error_free (err);
                        err = NULL;
                        sqlite3_close (sqlite);
-                       g_slice_free1 (sizeof (*new), new);
+                       g_free (new);
                        new = NULL;
                }
        }
@@ -285,7 +285,7 @@ rspamd_stat_cache_sqlite3_close (gpointer c)
        if (ctx != NULL) {
                rspamd_sqlite3_close_prstmt (ctx->db, ctx->prstmt);
                sqlite3_close (ctx->db);
-               g_slice_free1 (sizeof (*ctx), ctx);
+               g_free (ctx);
        }
 
 }
index 1d1d3b137f59621512512d40287f0b1cd8b9e261..e83c44a1cf138813846589c6b5bbd25e83266b54 100644 (file)
@@ -137,12 +137,12 @@ gboolean rspamd_ftok_cstr_equal (const rspamd_ftok_t *s,
  * | len | allocated | <data> -- fstring_t
  *                     <begin> -- tok
  *
- * tok is expected to be allocated with g_slice_alloc
+ * tok is expected to be allocated with g_malloc
  */
 void rspamd_fstring_mapped_ftok_free (gpointer p);
 
 /**
- * Map token to a specified string. Token must be freed using g_slice_free1
+ * Map token to a specified string. Token must be freed using g_free
  */
 rspamd_ftok_t *rspamd_ftok_map (const rspamd_fstring_t *s);
 
index 26251937e40fa91759bb8f5b0b7828c7bf278d62..a64afe4b01ef814cd1cb7fb4997384ce6e60fb48 100644 (file)
@@ -235,7 +235,7 @@ rspamadm_confighelp (gint argc, gchar **argv)
        /* Init modules to get documentation strings */
        for (pmod = cfg->compiled_modules; pmod != NULL && *pmod != NULL; pmod++) {
                mod = *pmod;
-               mod_ctx = g_slice_alloc0 (sizeof (struct module_ctx));
+               mod_ctx = g_malloc0 (sizeof (struct module_ctx));
 
                if (mod->module_init_func (cfg, &mod_ctx) == 0) {
                        g_hash_table_insert (cfg->c_modules,
index 92a43406498cdc5d0a0677a1432c87a16491f628..c286bffa951380a7ae2e6f0eb6c2b076d930cf1b 100644 (file)
@@ -332,7 +332,7 @@ rspamadm_fuzzy_merge (gint argc, gchar **argv)
                                 * local one then we replace dest value with the src value
                                 */
                                if (src_value > value && src_flag == flag) {
-                                       nop = g_slice_alloc (sizeof (*nop));
+                                       nop = g_malloc0 (sizeof (*nop));
                                        nop->op = OP_UPDATE;
                                        memcpy (nop->digest, digest,
                                                        sizeof (nop->digest));
@@ -355,7 +355,7 @@ rspamadm_fuzzy_merge (gint argc, gchar **argv)
                                                else {
                                                        ndup_other ++;
                                                }
-                                               g_slice_free1 (sizeof (*nop), nop);
+                                               g_free (nop);
                                        }
                                }
                                else {
@@ -366,7 +366,7 @@ rspamadm_fuzzy_merge (gint argc, gchar **argv)
                                /* Digest has not been found, but maybe we have the same in other
                                 * sources ?
                                 */
-                               nop = g_slice_alloc (sizeof (*nop));
+                               nop = g_malloc0 (sizeof (*nop));
                                nop->op = OP_INSERT;
                                memcpy (nop->digest, digest,
                                                sizeof (nop->digest));
@@ -393,7 +393,7 @@ rspamadm_fuzzy_merge (gint argc, gchar **argv)
                                        else {
                                                ndup_other++;
                                        }
-                                       g_slice_free1 (sizeof (*nop), nop);
+                                       g_free (nop);
                                }
                        }
                }
@@ -414,7 +414,7 @@ rspamadm_fuzzy_merge (gint argc, gchar **argv)
 
                                if ((op = g_hash_table_lookup (digests_id, &id)) != NULL) {
                                        /* value, number, digest_id */
-                                       nop = g_slice_alloc (sizeof (*nop));
+                                       nop = g_malloc0 (sizeof (*nop));
                                        nop->op = OP_INSERT_SHINGLE;
                                        memcpy (nop->digest, op->digest, sizeof (nop->digest));
                                        nop->data.shgl.number = sqlite3_column_int64 (shgl_stmt, 1);
@@ -547,7 +547,7 @@ rspamadm_fuzzy_merge (gint argc, gchar **argv)
        sqlite3_close (dest_db);
        for (i = 0; i < ops->len; i++) {
                op = g_ptr_array_index (ops, i);
-               g_slice_free1 (sizeof (*op), op);
+               g_free (op);
        }
        g_ptr_array_free (ops, TRUE);
        rspamd_mempool_delete (pool);
@@ -572,7 +572,7 @@ err:
        sqlite3_close (dest_db);
        for (i = 0; i < ops->len; i++) {
                op = g_ptr_array_index (ops, i);
-               g_slice_free1 (sizeof (*op), op);
+               g_free (op);
        }
        g_ptr_array_free (ops, TRUE);
        rspamd_mempool_delete (pool);
index 96b6940ae1be46d7e15941a593314096867004c5..f959c6bf3541ae21a7ad9b790fb832367083d0ab 100644 (file)
@@ -548,7 +548,7 @@ rspamadm_lua_accept_cb (gint fd, short what, void *arg)
                return;
        }
 
-       session = g_slice_alloc0 (sizeof (*session));
+       session = g_malloc0 (sizeof (*session));
        session->rt = ctx->rt;
        session->ctx = ctx;
        session->addr = addr;
@@ -571,7 +571,7 @@ rspamadm_lua_finish_handler (struct rspamd_http_connection_entry *conn_ent)
 {
        struct rspamadm_lua_repl_session *session = conn_ent->ud;
 
-       g_slice_free1 (sizeof (*session), session);
+       g_free (session);
 }
 
 /*
@@ -740,7 +740,7 @@ rspamadm_lua (gint argc, gchar **argv)
                }
 
                ev_base = event_init ();
-               ctx = g_slice_alloc0  (sizeof (*ctx));
+               ctx = g_malloc0  (sizeof (*ctx));
                http = rspamd_http_router_new (rspamadm_lua_error_handler,
                                                rspamadm_lua_finish_handler,
                                                NULL, ev_base,
@@ -758,7 +758,7 @@ rspamadm_lua (gint argc, gchar **argv)
                        if (fd != -1) {
                                struct event *ev;
 
-                               ev = g_slice_alloc0 (sizeof (*ev));
+                               ev = g_malloc0 (sizeof (*ev));
                                event_set (ev, fd, EV_READ|EV_PERSIST, rspamadm_lua_accept_cb,
                                                ctx);
                                event_base_set (ev_base, ev);