import org.sonar.server.es.SearchOptions;
import org.sonar.server.es.SearchResult;
import org.sonar.server.exceptions.BadRequestException;
-import org.sonar.server.exceptions.NotFoundException;
import org.sonar.server.issue.actionplan.ActionPlanService;
import org.sonar.server.issue.index.IssueDoc;
import org.sonar.server.issue.index.IssueIndex;
private final UserSession userSession;
public IssueService(DbClient dbClient, IssueIndex issueIndex,
- IssueWorkflow workflow,
- IssueStorage issueStorage,
- IssueUpdater issueUpdater,
- NotificationManager notificationService,
- ActionPlanService actionPlanService,
- RuleFinder ruleFinder,
- UserFinder userFinder,
- UserIndex userIndex, SourceLineIndex sourceLineIndex, UserSession userSession) {
+ IssueWorkflow workflow,
+ IssueStorage issueStorage,
+ IssueUpdater issueUpdater,
+ NotificationManager notificationService,
+ ActionPlanService actionPlanService,
+ RuleFinder ruleFinder,
+ UserFinder userFinder,
+ UserIndex userIndex, SourceLineIndex sourceLineIndex, UserSession userSession) {
this.dbClient = dbClient;
this.issueIndex = issueIndex;
this.workflow = workflow;
try {
Optional<ComponentDto> componentOptional = dbClient.componentDao().selectByKey(session, componentKey);
if (!componentOptional.isPresent()) {
- throw new NotFoundException(String.format("Component with key '%s' not found", componentKey));
+ throw new BadRequestException(String.format("Component with key '%s' not found", componentKey));
}
ComponentDto component = componentOptional.get();
ComponentDto project = dbClient.componentDao().selectOrFailByUuid(session, component.projectUuid());
import org.sonar.server.es.SearchResult;
import org.sonar.server.exceptions.BadRequestException;
import org.sonar.server.exceptions.ForbiddenException;
-import org.sonar.server.exceptions.NotFoundException;
import org.sonar.server.issue.index.IssueDoc;
import org.sonar.server.issue.index.IssueIndex;
import org.sonar.server.issue.index.IssueIndexDefinition;
}
@Test(expected = IllegalArgumentException.class)
- public void fail_create_manual_issue_if_rule_does_not_exists() {
+ public void fail_create_manual_issue_if_rule_does_not_exist() {
ComponentDto project = newProject();
ComponentDto file = newFile(project);
userSessionRule.login("john").addProjectPermissions(UserRole.USER, project.key());
service.createManualIssue(file.key(), rule.getKey(), 10, "Fix it", null);
}
- @Test(expected = NotFoundException.class)
+ @Test(expected = BadRequestException.class)
public void fail_to_create_manual_issue_on_unknown_component() {
ComponentDto project = newProject();
userSessionRule.login("john").addProjectPermissions(UserRole.USER, project.key());