Fix quality flaws

diff --git a/sonar-core/src/main/java/org/sonar/core/persistence/profiling/ProfilingDataSource.java b/sonar-core/src/main/java/org/sonar/core/persistence/profiling/ProfilingDataSource.java
index 90f0dd296b393a091e897b4ae38f552994078148..699b4cb257a62d9ee3a213683aa10b4be23e0414 100644 (file)
--- a/sonar-core/src/main/java/org/sonar/core/persistence/profiling/ProfilingDataSource.java
+++ b/sonar-core/src/main/java/org/sonar/core/persistence/profiling/ProfilingDataSource.java
@@ -307,12 +307,14 @@ class ProfilingDataSource extends BasicDataSource {
 
   @Override
   public Connection getConnection() throws SQLException {
-    return (Connection) Proxy.newProxyInstance(this.getClass().getClassLoader(), new Class[] { Connection.class }, new ProfilingConnectionHandler(delegate.getConnection()));
+    return (Connection) Proxy.newProxyInstance(this.getClass().getClassLoader(), new Class[] { Connection.class },
+        new ProfilingConnectionHandler(delegate.getConnection()));
   }
 
   @Override
   public Connection getConnection(String user, String pass) throws SQLException {
-    return (Connection) Proxy.newProxyInstance(this.getClass().getClassLoader(), new Class[] { Connection.class }, new ProfilingConnectionHandler(delegate.getConnection(user, pass)));
+    return (Connection) Proxy.newProxyInstance(this.getClass().getClassLoader(), new Class[] { Connection.class },
+        new ProfilingConnectionHandler(delegate.getConnection(user, pass)));
   }
 
   @Override

diff --git a/sonar-core/src/main/java/org/sonar/core/persistence/profiling/ProfilingPreparedStatementHandler.java b/sonar-core/src/main/java/org/sonar/core/persistence/profiling/ProfilingPreparedStatementHandler.java
index f773d8fb3c685e024c50dac81fd8b1ff567b2630..8785e517b4cd198b7872214dabd237c636461627 100644 (file)
--- a/sonar-core/src/main/java/org/sonar/core/persistence/profiling/ProfilingPreparedStatementHandler.java
+++ b/sonar-core/src/main/java/org/sonar/core/persistence/profiling/ProfilingPreparedStatementHandler.java
@@ -27,7 +27,7 @@ import java.sql.PreparedStatement;
 
 class ProfilingPreparedStatementHandler implements InvocationHandler {
 
-  private static final SqlProfiling profiling = new SqlProfiling();
+  private static final SqlProfiling PROFILING = new SqlProfiling();
   private final PreparedStatement statement;
   private final String sql;
 
@@ -39,9 +39,9 @@ class ProfilingPreparedStatementHandler implements InvocationHandler {
   @Override
   public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
     if (method.getName().startsWith("execute")) {
-      StopWatch watch = profiling.start();
+      StopWatch watch = PROFILING.start();
       Object result = method.invoke(statement, args);
-      profiling.stop(watch, sql);
+      PROFILING.stop(watch, sql);
       return result;
     } else {
       return method.invoke(statement, args);

diff --git a/sonar-core/src/main/java/org/sonar/core/persistence/profiling/ProfilingStatementHandler.java b/sonar-core/src/main/java/org/sonar/core/persistence/profiling/ProfilingStatementHandler.java
index 3180bf0ee1f5c4260fb97ce0b2ddeaee933df21d..0ba978796a6a37e683a67172c7bb28d77295e13f 100644 (file)
--- a/sonar-core/src/main/java/org/sonar/core/persistence/profiling/ProfilingStatementHandler.java
+++ b/sonar-core/src/main/java/org/sonar/core/persistence/profiling/ProfilingStatementHandler.java
@@ -27,7 +27,7 @@ import java.sql.Statement;
 
 class ProfilingStatementHandler implements InvocationHandler {
 
-  private static final SqlProfiling profiling = new SqlProfiling();
+  private static final SqlProfiling PROFILING = new SqlProfiling();
   private final Statement statement;
 
   ProfilingStatementHandler(Statement statement) {
@@ -37,9 +37,9 @@ class ProfilingStatementHandler implements InvocationHandler {
   @Override
   public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
     if (method.getName().startsWith("execute")) {
-      StopWatch watch = profiling.start();
+      StopWatch watch = PROFILING.start();
       Object result = method.invoke(statement, args);
-      profiling.stop(watch, (String) args[0]);
+      PROFILING.stop(watch, (String) args[0]);
       return result;
     } else {
       return method.invoke(statement, args);