[errorprone] RefDatabase: #getConflictingNames immutable return

Errorprone reports that: This method returns both mutable and
immutable collections or maps from different paths. This may be
confusing for users of the method.

Return always an immutable collection.

Change-Id: Id48f3645fd06c8bc72212af180d7d02c7e0b7632

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/lib/RefDatabase.java b/org.eclipse.jgit/src/org/eclipse/jgit/lib/RefDatabase.java
index 2cf24185c7b6f101f3624c5a5968d64550453418..114246beb2094348366afdc6aa27d508e6d28420 100644 (file)
--- a/org.eclipse.jgit/src/org/eclipse/jgit/lib/RefDatabase.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/lib/RefDatabase.java
@@ -160,7 +160,7 @@ public abstract class RefDatabase {
                        if (existing.startsWith(prefix))
                                conflicting.add(existing);
 
-               return conflicting;
+               return Collections.unmodifiableList(conflicting);
        }
 
        /**