has_many :workflow_transitions_as_new_status, :class_name => 'WorkflowTransition', :foreign_key => "new_status_id"
acts_as_list
+ after_update :handle_is_closed_change
before_destroy :delete_workflow_rules
validates_presence_of :name
private
+ # Updates issues closed_on attribute when an existing status is set as closed.
+ def handle_is_closed_change
+ if is_closed_changed? && is_closed == true
+ # First we update issues that have a journal for when the current status was set,
+ # a subselect is used to update all issues with a single query
+ subselect = "SELECT MAX(j.created_on) FROM #{Journal.table_name} j" +
+ " JOIN #{JournalDetail.table_name} d ON d.journal_id = j.id" +
+ " WHERE j.journalized_type = 'Issue' AND j.journalized_id = #{Issue.table_name}.id" +
+ " AND d.property = 'attr' AND d.prop_key = 'status_id' AND d.value = :status_id"
+ Issue.where(:status_id => id, :closed_on => nil).update_all(["closed_on = (#{subselect})", :status_id => id.to_s])
+
+ # Then we update issues that don't have a journal which means the
+ # current status was set on creation
+ Issue.where(:status_id => id, :closed_on => nil).update_all("closed_on = created_on")
+ end
+ end
+
def check_integrity
if Issue.where(:status_id => id).any?
raise "This status is used by some issues"
assert_not_nil status
assert_equal "Resolved", status.name
end
+
+ def test_setting_status_as_closed_should_set_closed_on_for_issues_without_status_journal
+ issue = Issue.generate!(:status_id => 1, :created_on => 2.days.ago)
+ assert_nil issue.closed_on
+
+ issue.status.update! :is_closed => true
+
+ issue.reload
+ assert issue.closed?
+ assert_equal issue.created_on, issue.closed_on
+ end
+
+ def test_setting_status_as_closed_should_set_closed_on_for_issues_with_status_journal
+ issue = Issue.generate!(:status_id => 1, :created_on => 2.days.ago)
+ issue.init_journal(User.find(1))
+ issue.status_id = 2
+ issue.save!
+
+ issue.status.update! :is_closed => true
+
+ issue.reload
+ assert issue.closed?
+ assert_equal issue.journals.first.created_on, issue.closed_on
+ end
+
+ def test_setting_status_as_closed_should_not_set_closed_on_for_issues_with_other_status
+ issue = Issue.generate!(:status_id => 2)
+
+ IssueStatus.find(1).update! :is_closed => true
+
+ issue.reload
+ assert !issue.closed?
+ assert_nil issue.closed_on
+ end
end