]> source.dussan.org Git - jquery.git/commitdiff
Tests: Make more tests run natively in Chrome & Firefox
authorMichał Gołębiowski-Owczarek <m.goleb@gmail.com>
Tue, 13 Apr 2021 20:11:45 +0000 (22:11 +0200)
committerGitHub <noreply@github.com>
Tue, 13 Apr 2021 20:11:45 +0000 (22:11 +0200)
Chrome & Firefox now support complex `:not()` selectors so those test can run
in them even without custom jQuery selector code. In the past, it was only
possible in Safari, now we only need to exclude IE.

Closes gh-4864

test/unit/selector.js

index b11b801c6b78470d056d675d5017bea64611675e..41d9d0f70a41b899b213ab59f3ab21d6505b45b5 100644 (file)
@@ -1137,14 +1137,14 @@ QUnit.test( "pseudo - :not", function( assert ) {
        assert.t( ":not() failing interior", "#qunit-fixture p:not(.foo)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
        assert.t( ":not() failing interior", "#qunit-fixture p:not(#blargh)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
 
-       if ( QUnit.jQuerySelectors || this.safari ) {
+       if ( QUnit.jQuerySelectors || !QUnit.isIE ) {
                assert.t( ":not() failing interior", "#qunit-fixture p:not(div.foo)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
                assert.t( ":not() failing interior", "#qunit-fixture p:not(p.foo)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
                assert.t( ":not() failing interior", "#qunit-fixture p:not(div#blargh)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
                assert.t( ":not() failing interior", "#qunit-fixture p:not(p#blargh)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
        } else {
-               // Support: Chrome 75+, Firefox 67+
-               // Chrome/Firefox don't support `:not(complex selector)`.
+               // Support: IE 11+
+               // IE doesn't support `:not(complex selector)`.
                assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
                assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
                assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
@@ -1156,15 +1156,15 @@ QUnit.test( "pseudo - :not", function( assert ) {
        assert.t( ":not Multiple", "#qunit-fixture p:not( p )", [] );
        assert.t( ":not Multiple", "p:not(p)", [] );
 
-       if ( QUnit.jQuerySelectors || this.safari ) {
+       if ( QUnit.jQuerySelectors || !QUnit.isIE ) {
                assert.t( ":not Multiple", "#qunit-fixture p:not(a, b)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
                assert.t( ":not Multiple", "#qunit-fixture p:not(a, b, div)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
                assert.t( ":not Multiple", "p:not(a,p)", [] );
                assert.t( ":not Multiple", "p:not(p,a)", [] );
                assert.t( ":not Multiple", "p:not(a,p,b)", [] );
        } else {
-               // Support: Chrome 75+, Firefox 67+
-               // Chrome/Firefox don't support `:not(complex selector)`.
+               // Support: IE 11+
+               // IE doesn't support `:not(complex selector)`.
                assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
                assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
                assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
@@ -1189,11 +1189,11 @@ QUnit.test( "pseudo - :not", function( assert ) {
        assert.t( ":not() Multiple Class", "#foo a:not(.blog)", [ "yahoo", "anchor2" ] );
        assert.t( ":not() Multiple Class", "#foo a:not(.link)", [ "yahoo", "anchor2" ] );
 
-       if ( QUnit.jQuerySelectors || this.safari ) {
+       if ( QUnit.jQuerySelectors || !QUnit.isIE ) {
                assert.t( ":not() Multiple Class", "#foo a:not(.blog.link)", [ "yahoo", "anchor2" ] );
        } else {
-               // Support: Chrome 75+, Firefox 67+
-               // Chrome/Firefox don't support `:not(complex selector)`.
+               // Support: IE 11+
+               // IE doesn't support `:not(complex selector)`.
                assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
        }