DoPrivileged do not set anymore a System user

diff --git a/sonar-server/src/main/java/org/sonar/server/qualitygate/QualityGates.java b/sonar-server/src/main/java/org/sonar/server/qualitygate/QualityGates.java
index 924eb4a914cd4e05943b8311faaaefe544a012bd..9d1fcc9872b7f56c0fa9ea95895267d2c7f0d9da 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/qualitygate/QualityGates.java
+++ b/sonar-server/src/main/java/org/sonar/server/qualitygate/QualityGates.java
@@ -39,11 +39,7 @@ import org.sonar.core.qualitygate.db.QualityGateConditionDto;
 import org.sonar.core.qualitygate.db.QualityGateDao;
 import org.sonar.core.qualitygate.db.QualityGateDto;
 import org.sonar.server.component.persistence.ComponentDao;
-import org.sonar.server.exceptions.BadRequestException;
-import org.sonar.server.exceptions.Errors;
-import org.sonar.server.exceptions.Message;
-import org.sonar.server.exceptions.NotFoundException;
-import org.sonar.server.exceptions.ServerException;
+import org.sonar.server.exceptions.*;
 import org.sonar.server.user.UserSession;
 import org.sonar.server.util.Validation;
 
@@ -364,7 +360,6 @@ public class QualityGates {
   }
 
   private void checkPermission(UserSession userSession) {
-    userSession.checkLoggedIn();
     userSession.checkGlobalPermission(GlobalPermissions.QUALITY_PROFILE_ADMIN);
   }
 }

diff --git a/sonar-server/src/main/java/org/sonar/server/user/DoPrivileged.java b/sonar-server/src/main/java/org/sonar/server/user/DoPrivileged.java
index edae46ab7aea7a34df1463e0f108d44a8c7a8903..954191b136bc89711b015d82c6b79b7765841ec0 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/user/DoPrivileged.java
+++ b/sonar-server/src/main/java/org/sonar/server/user/DoPrivileged.java
@@ -29,9 +29,6 @@ import java.util.Locale;
  */
 public final class DoPrivileged {
 
-  private static final String SYSTEM_LOGIN = "<system>";
-  private static final String SYSTEM_NAME = "<System>";
-
   private DoPrivileged() {
     // Only static stuff
   }
@@ -70,7 +67,7 @@ public final class DoPrivileged {
         public boolean hasProjectPermission(String permission, String projectKey) {
           return true;
         }
-      }.setLocale(Locale.getDefault()).setLogin(SYSTEM_LOGIN).setName(SYSTEM_NAME));
+      }.setLocale(Locale.getDefault()));
     }
   
     private void stop() {

diff --git a/sonar-server/src/test/java/org/sonar/server/user/DoPrivilegedTest.java b/sonar-server/src/test/java/org/sonar/server/user/DoPrivilegedTest.java
index e1db8f717b786343cc39a0a4bc70f3076629590e..75a8bc7a32b37d072dd9ae10d654ae0a6b2a19c7 100644 (file)
--- a/sonar-server/src/test/java/org/sonar/server/user/DoPrivilegedTest.java
+++ b/sonar-server/src/test/java/org/sonar/server/user/DoPrivilegedTest.java
@@ -31,7 +31,7 @@ public class DoPrivilegedTest {
       @Override
       protected void doPrivileged() {
         UserSession userSession = UserSession.get();
-        assertThat(userSession.isLoggedIn()).isTrue();
+        assertThat(userSession.isLoggedIn()).isFalse();
         assertThat(userSession.hasGlobalPermission("any permission")).isTrue();
         assertThat(userSession.hasProjectPermission("any permission", "any project")).isTrue();
       }