]> source.dussan.org Git - vaadin-framework.git/commitdiff
Make BaseThemeTest more stable on IE11
authorHenri Sara <hesara@vaadin.com>
Thu, 31 Aug 2017 06:08:10 +0000 (09:08 +0300)
committerHenri Sara <henri.sara@gmail.com>
Thu, 31 Aug 2017 06:50:13 +0000 (09:50 +0300)
Try to make the test more stable by using a different way of
detecting the presence of a notification. This approach is used e.g.
in GridComponentsTest.

uitest/src/test/java/com/vaadin/tests/components/uitest/ThemeTest.java

index f6f88baafe4caa8520328876e301cf195183e1e7..39ee947fb63b95c2c36f95275b8696f5066f1002 100644 (file)
@@ -129,7 +129,8 @@ public abstract class ThemeTest extends MultiBrowserTest {
     private void testNotification(int id, String identifier)
             throws IOException {
         $(ButtonElement.class).id("notifButt" + id).click();
-        waitForElementPresent(By.className("v-Notification"));
+        // For some reason, this seems to be more reliable on IE11
+        waitUntil(driver -> isElementPresent(NotificationElement.class), 10);
         compareScreen(identifier);
         $(NotificationElement.class).first().close();
     }