private final String name;
private final Logger delegate;
- public FilteredLogger() {
- this(null);
- }
-
private FilteredLogger(String name) {
this.name = name;
this.delegate = new StdErrLog(name);
public void info(String msg, Object arg0, Object arg1) {
if (msg.contains("JVM BUG(s)")) {
- return; // Ignore, see SONAR-3866
+ // Ignore, see SONAR-3866
+ return;
}
delegate.info(msg, arg0, arg1);
}
import org.sonar.api.measures.Measure;
import org.sonar.api.measures.MeasuresFilter;
import org.sonar.api.measures.Metric;
-import org.sonar.api.resources.DuplicatedSourceException;
import org.sonar.api.resources.Project;
import org.sonar.api.resources.ProjectLink;
import org.sonar.api.resources.Resource;
if (checkPriority == Priority.INFO) {
return RulePriority.INFO;
}
- return null;
- }
-
- public Priority toCheckPriority() {
- if (this == BLOCKER) {
- return Priority.BLOCKER;
- }
- if (this == CRITICAL) {
- return Priority.CRITICAL;
- }
- if (this == MAJOR) {
- return Priority.MAJOR;
- }
- if (this == MINOR) {
- return Priority.MINOR;
- }
- if (this == INFO) {
- return Priority.INFO;
- }
- return null;
+ throw new IllegalArgumentException("Unknown priority " + checkPriority);
}
}
\ No newline at end of file
import org.apache.commons.io.FileUtils;
import org.apache.commons.io.IOUtils;
-import java.io.*;
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
import java.util.Enumeration;
import java.util.zip.ZipEntry;
import java.util.zip.ZipFile;
/**
* Unzip a file into a new temporary directory. The directory is not deleted on JVM exit, so it
- * must be explicitely deleted.
+ * must be explicitely deleted.
+ *
* @return the temporary directory
* @since 2.2
- * @deprecated since 3.4 use by {@link org.sonar.api.resources.ProjectFileSystem#getSonarWorkingDirectory} or {@link org.sonar.api.platform.ServerFileSystem#getTempDir}
+ * @deprecated since 3.4 use by {@link org.sonar.api.scan.filesystem.ModuleFileSystem#workingDir()} or {@link org.sonar.api.platform.ServerFileSystem#getTempDir}
*/
@Deprecated
public static File unzipToTempDir(File zip) throws IOException {
File toDir = TempFileUtils.createTempDirectory();
- unzip (zip, toDir);
+ unzip(zip, toDir);
return toDir;
}
/**
* Unzip a file into a directory. The directory is created if it does not exist.
+ *
* @return the target directory
*/
public static File unzip(File zip, File toDir) throws IOException {
}
}
return toDir;
-
+
} finally {
zipFile.close();
}
try {
out = FileUtils.openOutputStream(zip);
zout = new ZipOutputStream(out);
- zip(dir, zout, null);
+ zip(dir, zout);
} finally {
IOUtils.closeQuietly(zout);
}
}
- private static void zip(File file, ZipOutputStream out, String prefix) throws IOException {
- if (prefix != null) {
- int len = prefix.length();
- if (len == 0) {
- prefix = null;
- } else if (prefix.charAt(len - 1) != '/') {
- prefix += '/';
- }
- }
+ private static void zip(File file, ZipOutputStream out) throws IOException {
for (File child : file.listFiles()) {
- String name = prefix != null ? prefix + child.getName() : child.getName();
+ String name = child.getName();
_zip(name, child, out);
}
}
*/
package org.sonar.api.rules;
-import junit.framework.Assert;
import org.junit.Test;
+import org.sonar.check.Priority;
+
+import static org.fest.assertions.Assertions.assertThat;
public class RulePriorityTest {
@Test
public void testValueOfString() {
- Assert.assertEquals(RulePriority.INFO, RulePriority.valueOfString("info"));
- Assert.assertEquals(RulePriority.MAJOR, RulePriority.valueOfString("MAJOR"));
- Assert.assertEquals(RulePriority.MAJOR, RulePriority.valueOfString("ERROR"));
- Assert.assertEquals(RulePriority.INFO, RulePriority.valueOfString("WARNING"));
- Assert.assertEquals(RulePriority.MAJOR, RulePriority.valueOfString("ErRor"));
- Assert.assertEquals(RulePriority.INFO, RulePriority.valueOfString("WaRnInG"));
+ assertThat(RulePriority.INFO).isEqualTo(RulePriority.valueOfString("info"));
+ assertThat(RulePriority.MAJOR).isEqualTo(RulePriority.valueOfString("MAJOR"));
+ assertThat(RulePriority.MAJOR).isEqualTo(RulePriority.valueOfString("ERROR"));
+ assertThat(RulePriority.INFO).isEqualTo(RulePriority.valueOfString("WARNING"));
+ assertThat(RulePriority.MAJOR).isEqualTo(RulePriority.valueOfString("ErRor"));
+ assertThat(RulePriority.INFO).isEqualTo(RulePriority.valueOfString("WaRnInG"));
}
@Test(expected = IllegalArgumentException.class)
RulePriority.valueOfString("make me crash");
}
+ @Test
+ public void test_toCheckPriority() {
+ assertThat(RulePriority.fromCheckPriority(Priority.BLOCKER)).isEqualTo(RulePriority.BLOCKER);
+ assertThat(RulePriority.fromCheckPriority(Priority.CRITICAL)).isEqualTo(RulePriority.CRITICAL);
+ assertThat(RulePriority.fromCheckPriority(Priority.MAJOR)).isEqualTo(RulePriority.MAJOR);
+ assertThat(RulePriority.fromCheckPriority(Priority.MINOR)).isEqualTo(RulePriority.MINOR);
+ assertThat(RulePriority.fromCheckPriority(Priority.INFO)).isEqualTo(RulePriority.INFO);
+ }
}
import org.junit.Test;
import org.sonar.colorizer.Tokenizer;
-import static org.hamcrest.CoreMatchers.is;
-import static org.junit.Assert.assertThat;
+import static org.fest.assertions.Assertions.assertThat;
public class CodeColorizerFormatTest {
@Test
public void keyIsLanguage() {
CodeColorizerFormat format = new FakeFormat("foo");
- assertThat(format.getLanguageKey(), is("foo"));
+ assertThat(format.getLanguageKey()).isEqualTo("foo");
- assertThat(format.equals(new FakeFormat("foo")), is(true));
- assertThat(format.equals(new FakeFormat("bar")), is(false));
+ assertThat(format.equals(new FakeFormat("foo"))).isTrue();
+ assertThat(format.equals(new FakeFormat("bar"))).isFalse();
+ assertThat(format.hashCode()).isEqualTo(format.hashCode());
+ assertThat(format.hashCode()).isEqualTo(new FakeFormat("foo").hashCode());
}
private static class FakeFormat extends CodeColorizerFormat {
.global_violations {
width: 100%;
- margin-bottom: 10px;
}
.global_violations > tbody > tr > td {