fix(settings): users page html validation

- Remove non-existing `button-class` from `NcAppNavigationNew`
- Type: use `input-id` instead of `id` on `NcSelect` to be labeled
- Encode uniqueId with user's ID, because user.id may contain space

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

diff --git a/apps/settings/src/components/Users/UserRow.vue b/apps/settings/src/components/Users/UserRow.vue
index d62780d2b61020a9c37986a91cd714bc45976c48..8b39e611044cf293e0b1a1722cfa366316087dbf 100644 (file)
--- a/apps/settings/src/components/Users/UserRow.vue
+++ b/apps/settings/src/components/Users/UserRow.vue
@@ -150,7 +150,7 @@
                                        :for="'subadmins' + uniqueId">
                                        {{ t('settings', 'Set user as admin for') }}
                                </label>
-                               <NcSelect :id="'subadmins' + uniqueId"
+                               <NcSelect :input-id="'subadmins' + uniqueId"
                                        :close-on-select="false"
                                        :disabled="isLoadingField"
                                        :loading="loading.subadmins"
@@ -406,7 +406,7 @@ export default {
                },
 
                uniqueId() {
-                       return this.user.id + this.rand
+                       return encodeURIComponent(this.user.id + this.rand)
                },
 
                userGroupsLabels() {

diff --git a/apps/settings/src/views/Users.vue b/apps/settings/src/views/Users.vue
index 13a7d46d25678abefc71d2796e3845f9df601fb1..f6c61998a733585300b7654f4e557ad01565186c 100644 (file)
--- a/apps/settings/src/views/Users.vue
+++ b/apps/settings/src/views/Users.vue
@@ -26,7 +26,6 @@
                        <NcAppNavigation>
                                <NcAppNavigationNew button-id="new-user-button"
                                        :text="t('settings','New user')"
-                                       button-class="icon-add"
                                        @click="showNewUserMenu"
                                        @keyup.enter="showNewUserMenu"
                                        @keyup.space="showNewUserMenu">