skip the files_external test cases the correct way

diff --git a/apps/files_external/tests/amazons3.php b/apps/files_external/tests/amazons3.php
index b9b4cf65bd674a71631954321792b9cfbc2cbe02..725f4ba05daafb449a9c84ede2edf84132325859 100644 (file)
--- a/apps/files_external/tests/amazons3.php
+++ b/apps/files_external/tests/amazons3.php
@@ -1,43 +1,42 @@
 <?php
 
 /**
-* ownCloud
-*
-* @author Michael Gapczynski
-* @copyright 2012 Michael Gapczynski mtgap@owncloud.com
-*
-* This library is free software; you can redistribute it and/or
-* modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
-* License as published by the Free Software Foundation; either
-* version 3 of the License, or any later version.
-*
-* This library is distributed in the hope that it will be useful,
-* but WITHOUT ANY WARRANTY; without even the implied warranty of
-* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-* GNU AFFERO GENERAL PUBLIC LICENSE for more details.
-*
-* You should have received a copy of the GNU Affero General Public
-* License along with this library.  If not, see <http://www.gnu.org/licenses/>.
-*/
+ * ownCloud
+ *
+ * @author Michael Gapczynski
+ * @copyright 2012 Michael Gapczynski mtgap@owncloud.com
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU AFFERO GENERAL PUBLIC LICENSE for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public
+ * License along with this library.  If not, see <http://www.gnu.org/licenses/>.
+ */
 
-$config = include('apps/files_external/tests/config.php');
-if (!is_array($config) or !isset($config['amazons3']) or !$config['amazons3']['run']) {
-       abstract class Test_Filestorage_AmazonS3 extends Test_FileStorage{}
-       return;
-} else {
-       class Test_Filestorage_AmazonS3 extends Test_FileStorage {
+class Test_Filestorage_AmazonS3 extends Test_FileStorage {
 
-               private $config;
-               private $id;
+       private $config;
+       private $id;
 
-               public function setUp() {
-                       $id = uniqid();
-                       $this->config = include('apps/files_external/tests/config.php');
-                       $this->config['amazons3']['bucket'] = $id; // Make sure we have a new empty bucket to work in
-                       $this->instance = new OC_Filestorage_AmazonS3($this->config['amazons3']);
+       public function setUp() {
+               $id = uniqid();
+               $this->config = include('files_external/tests/config.php');
+               if (!is_array($this->config) or !isset($this->config['amazons3']) or !$this->config['amazons3']['run']) {
+                       $this->markTestSkipped('AmazonS3 backend not configured');
                }
+               $this->config['amazons3']['bucket'] = $id; // Make sure we have a new empty bucket to work in
+               $this->instance = new OC_Filestorage_AmazonS3($this->config['amazons3']);
+       }
 
-               public function tearDown() {
+       public function tearDown() {
+               if ($this->instance) {
                        $s3 = new AmazonS3(array('key' => $this->config['amazons3']['key'], 'secret' => $this->config['amazons3']['secret']));
                        if ($s3->delete_all_objects($this->id)) {
                                $s3->delete_bucket($this->id);

diff --git a/apps/files_external/tests/config.php b/apps/files_external/tests/config.php
index 7779f6189483839385abcb62542e6a95f752617b..47dd7c4bf877efedaa4c5bfd33c922d0f9d8e55e 100644 (file)
--- a/apps/files_external/tests/config.php
+++ b/apps/files_external/tests/config.php
@@ -8,7 +8,7 @@ return array(
                'root'=>'/test',
        ),
        'webdav'=>array(
-               'run'=>false,
+               'run'=>true,
                'host'=>'localhost',
                'user'=>'test',
                'password'=>'test',
@@ -26,11 +26,11 @@ return array(
                'run'=>false,
                'user'=>'test:tester',
                'token'=>'testing',
-               'host'=>'localhost:8080/auth',
+               'host'=>'ubuntu.local:8080/auth',
                'root'=>'/',
        ),
        'smb'=>array(
-               'run'=>false,
+               'run'=>true,
                'user'=>'test',
                'password'=>'test',
                'host'=>'localhost',

diff --git a/apps/files_external/tests/dropbox.php b/apps/files_external/tests/dropbox.php
index 64eb2556c9235846911f12e9866b7e8eed7826e6..56319b9f5d7194c560001cd7c4a4c5b6b2520354 100644 (file)
--- a/apps/files_external/tests/dropbox.php
+++ b/apps/files_external/tests/dropbox.php
@@ -6,22 +6,21 @@
  * See the COPYING-README file.
  */
 
-$config=include('files_external/tests/config.php');
-if(!is_array($config) or !isset($config['dropbox']) or !$config['dropbox']['run']) {
-       abstract class Test_Filestorage_Dropbox extends Test_FileStorage{}
-       return;
-}else{
-       class Test_Filestorage_Dropbox extends Test_FileStorage {
-               private $config;
+class Test_Filestorage_Dropbox extends Test_FileStorage {
+       private $config;
 
-               public function setUp() {
-                       $id=uniqid();
-                       $this->config=include('files_external/tests/config.php');
-                       $this->config['dropbox']['root'].='/'.$id;//make sure we have an new empty folder to work in
-                       $this->instance=new OC_Filestorage_Dropbox($this->config['dropbox']);
+       public function setUp() {
+               $id = uniqid();
+               $this->config = include('files_external/tests/config.php');
+               if (!is_array($this->config) or !isset($this->config['dropbox']) or !$this->config['dropbox']['run']) {
+                       $this->markTestSkipped('Dropbox backend not configured');
                }
+               $this->config['dropbox']['root'] .= '/' . $id; //make sure we have an new empty folder to work in
+               $this->instance = new OC_Filestorage_Dropbox($this->config['dropbox']);
+       }
 
-               public function tearDown() {
+       public function tearDown() {
+               if ($this->instance) {
                        $this->instance->unlink('/');
                }
        }

diff --git a/apps/files_external/tests/ftp.php b/apps/files_external/tests/ftp.php
index 12f3ec3908df4cd431749365c7e301c4c86d8f1e..4549c4204101903ffca58c24bc38706bb40a05ad 100644 (file)
--- a/apps/files_external/tests/ftp.php
+++ b/apps/files_external/tests/ftp.php
@@ -6,22 +6,21 @@
  * See the COPYING-README file.
  */
 
-$config=include('apps/files_external/tests/config.php');
-if(!is_array($config) or !isset($config['ftp']) or !$config['ftp']['run']) {
-       abstract class Test_Filestorage_FTP extends Test_FileStorage{}
-       return;
-}else{
-       class Test_Filestorage_FTP extends Test_FileStorage {
-               private $config;
+class Test_Filestorage_FTP extends Test_FileStorage {
+       private $config;
 
-               public function setUp() {
-                       $id=uniqid();
-                       $this->config=include('apps/files_external/tests/config.php');
-                       $this->config['ftp']['root'].='/'.$id;//make sure we have an new empty folder to work in
-                       $this->instance=new OC_Filestorage_FTP($this->config['ftp']);
+       public function setUp() {
+               $id = uniqid();
+               $this->config = include('files_external/tests/config.php');
+               if (!is_array($this->config) or !isset($this->config['ftp']) or !$this->config['ftp']['run']) {
+                       $this->markTestSkipped('FTP backend not configured');
                }
+               $this->config['ftp']['root'] .= '/' . $id; //make sure we have an new empty folder to work in
+               $this->instance = new OC_Filestorage_FTP($this->config['ftp']);
+       }
 
-               public function tearDown() {
+       public function tearDown() {
+               if ($this->instance) {
                        OCP\Files::rmdirr($this->instance->constructUrl(''));
                }
        }

diff --git a/apps/files_external/tests/google.php b/apps/files_external/tests/google.php
index d2a6358ade4fde28d29982c248fff2bc4ae0b567..46e622cc180fc1c2fceaf0676a4c9bab24ef8b7b 100644 (file)
--- a/apps/files_external/tests/google.php
+++ b/apps/files_external/tests/google.php
@@ -1,42 +1,41 @@
 <?php
 
 /**
-* ownCloud
-*
-* @author Michael Gapczynski
-* @copyright 2012 Michael Gapczynski mtgap@owncloud.com
-*
-* This library is free software; you can redistribute it and/or
-* modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
-* License as published by the Free Software Foundation; either
-* version 3 of the License, or any later version.
-*
-* This library is distributed in the hope that it will be useful,
-* but WITHOUT ANY WARRANTY; without even the implied warranty of
-* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-* GNU AFFERO GENERAL PUBLIC LICENSE for more details.
-*
-* You should have received a copy of the GNU Affero General Public
-* License along with this library.  If not, see <http://www.gnu.org/licenses/>.
-*/
+ * ownCloud
+ *
+ * @author Michael Gapczynski
+ * @copyright 2012 Michael Gapczynski mtgap@owncloud.com
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU AFFERO GENERAL PUBLIC LICENSE for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public
+ * License along with this library.  If not, see <http://www.gnu.org/licenses/>.
+ */
 
-$config=include('apps/files_external/tests/config.php');
-if(!is_array($config) or !isset($config['google']) or !$config['google']['run']) {
-       abstract class Test_Filestorage_Google extends Test_FileStorage{}
-       return;
-}else{
-       class Test_Filestorage_Google extends Test_FileStorage {
+class Test_Filestorage_Google extends Test_FileStorage {
 
-               private $config;
+       private $config;
 
-               public function setUp() {
-                       $id=uniqid();
-                       $this->config=include('apps/files_external/tests/config.php');
-                       $this->config['google']['root'].='/'.$id;//make sure we have an new empty folder to work in
-                       $this->instance=new OC_Filestorage_Google($this->config['google']);
+       public function setUp() {
+               $id = uniqid();
+               $this->config = include('files_external/tests/config.php');
+               if (!is_array($this->config) or !isset($this->config['google']) or !$this->config['google']['run']) {
+                       $this->markTestSkipped('Google backend not configured');
                }
+               $this->config['google']['root'] .= '/' . $id; //make sure we have an new empty folder to work in
+               $this->instance = new OC_Filestorage_Google($this->config['google']);
+       }
 
-               public function tearDown() {
+       public function tearDown() {
+               if ($this->instance) {
                        $this->instance->rmdir('/');
                }
        }

diff --git a/apps/files_external/tests/smb.php b/apps/files_external/tests/smb.php
index 7de4fddbb3425bbd1d2296b0da97ab39547fd8dd..2c03ef5dbd09569646288a3ef288db0d3b864a3e 100644 (file)
--- a/apps/files_external/tests/smb.php
+++ b/apps/files_external/tests/smb.php
@@ -6,23 +6,21 @@
  * See the COPYING-README file.
  */
 
-$config=include('apps/files_external/tests/config.php');
+class Test_Filestorage_SMB extends Test_FileStorage {
+       private $config;
 
-if(!is_array($config) or !isset($config['smb']) or !$config['smb']['run']) {
-       abstract class Test_Filestorage_SMB extends Test_FileStorage{}
-       return;
-}else{
-       class Test_Filestorage_SMB extends Test_FileStorage {
-               private $config;
-
-               public function setUp() {
-                       $id=uniqid();
-                       $this->config=include('apps/files_external/tests/config.php');
-                       $this->config['smb']['root'].=$id;//make sure we have an new empty folder to work in
-                       $this->instance=new OC_Filestorage_SMB($this->config['smb']);
+       public function setUp() {
+               $id = uniqid();
+               $this->config = include('files_external/tests/config.php');
+               if (!is_array($this->config) or !isset($this->config['smb']) or !$this->config['smb']['run']) {
+                       $this->markTestSkipped('Samba backend not configured');
                }
+               $this->config['smb']['root'] .= $id; //make sure we have an new empty folder to work in
+               $this->instance = new OC_Filestorage_SMB($this->config['smb']);
+       }
 
-               public function tearDown() {
+       public function tearDown() {
+               if ($this->instance) {
                        OCP\Files::rmdirr($this->instance->constructUrl(''));
                }
        }

diff --git a/apps/files_external/tests/swift.php b/apps/files_external/tests/swift.php
index a6f5eace1c862c76a0d1c7f69dd7f976345eab4a..8cf2a3abc76e940f61ef330173c18032955f1b3e 100644 (file)
--- a/apps/files_external/tests/swift.php
+++ b/apps/files_external/tests/swift.php
@@ -6,25 +6,23 @@
  * See the COPYING-README file.
  */
 
-$config=include('apps/files_external/tests/config.php');
-if(!is_array($config) or !isset($config['swift']) or !$config['swift']['run']) {
-       abstract class Test_Filestorage_SWIFT extends Test_FileStorage{}
-       return;
-}else{
-       class Test_Filestorage_SWIFT extends Test_FileStorage {
-               private $config;
+class Test_Filestorage_SWIFT extends Test_FileStorage {
+       private $config;
 
-               public function setUp() {
-                       $id=uniqid();
-                       $this->config=include('apps/files_external/tests/config.php');
-                       $this->config['swift']['root'].='/'.$id;//make sure we have an new empty folder to work in
-                       $this->instance=new OC_Filestorage_SWIFT($this->config['swift']);
+       public function setUp() {
+               $id = uniqid();
+               $this->config = include('files_external/tests/config.php');
+               if (!is_array($this->config) or !isset($this->config['swift']) or !$this->config['swift']['run']) {
+                       $this->markTestSkipped('OpenStack SWIFT backend not configured');
                }
+               $this->config['swift']['root'] .= '/' . $id; //make sure we have an new empty folder to work in
+               $this->instance = new OC_Filestorage_SWIFT($this->config['swift']);
+       }
 
 
-               public function tearDown() {
-                   $this->instance->rmdir('');
+       public function tearDown() {
+               if ($this->instance) {
+                       $this->instance->rmdir('');
                }
-
        }
 }

diff --git a/apps/files_external/tests/webdav.php b/apps/files_external/tests/webdav.php
index 74d980aa3f16c726bdab7b8ac8cf94759fb7f75a..2da88f63edd696fea108f565f021b791d8e16bbd 100644 (file)
--- a/apps/files_external/tests/webdav.php
+++ b/apps/files_external/tests/webdav.php
@@ -6,22 +6,21 @@
  * See the COPYING-README file.
  */
 
-$config=include('apps/files_external/tests/config.php');
-if(!is_array($config) or !isset($config['webdav']) or !$config['webdav']['run']) {
-       abstract class Test_Filestorage_DAV extends Test_FileStorage{}
-       return;
-}else{
-       class Test_Filestorage_DAV extends Test_FileStorage {
-               private $config;
+class Test_Filestorage_DAV extends Test_FileStorage {
+       private $config;
 
-               public function setUp() {
-                       $id=uniqid();
-                       $this->config=include('apps/files_external/tests/config.php');
-                       $this->config['webdav']['root'].='/'.$id;//make sure we have an new empty folder to work in
-                       $this->instance=new OC_Filestorage_DAV($this->config['webdav']);
+       public function setUp() {
+               $id = uniqid();
+               $this->config = include('files_external/tests/config.php');
+               if (!is_array($this->config) or !isset($this->config['webdav']) or !$this->config['webdav']['run']) {
+                       $this->markTestSkipped('WebDAV backend not configured');
                }
+               $this->config['webdav']['root'] .= '/' . $id; //make sure we have an new empty folder to work in
+               $this->instance = new OC_Filestorage_DAV($this->config['webdav']);
+       }
 
-               public function tearDown() {
+       public function tearDown() {
+               if ($this->instance) {
                        $this->instance->rmdir('/');
                }
        }