]> source.dussan.org Git - aspectj.git/commitdiff
AtAjLTWTests: 4 test cases switched to 'useFullLTW' mode
authorAlexander Kriegisch <Alexander@Kriegisch.name>
Wed, 23 Mar 2022 01:43:57 +0000 (08:43 +0700)
committerAlexander Kriegisch <Alexander@Kriegisch.name>
Wed, 23 Mar 2022 01:43:57 +0000 (08:43 +0700)
After the Java 18 JDT Core upgrade, some LTW tests are failing and
have to be switched from in-process to full LTW mode due to them now
obviously calling some code paths which need '--add-opens'.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
tests/src/test/java/org/aspectj/systemtest/ajc150/ataspectj/AtAjLTWTests.java
tests/src/test/resources/org/aspectj/systemtest/ajc150/ataspectj/ltw.xml

index c7be1944c535d40ef5226a48ecdbeb336aaee3f4..e06a3b0c36f31dbb8e5b368747e807ee4e0ed188 100644 (file)
@@ -121,11 +121,12 @@ public class AtAjLTWTests extends XMLBasedAjcTestCase {
        public void testLTWDumpClosure() {
                runTest("LTW DumpTest closure");
 
-               File f = new File("_ajdump/ataspectj/DumpTestTheDump$AjcClosure1.class");
+               // Test runs with 'usefullltw="true"' -> dump files are created in the sandbox directory
+               File f = new File(ajc.getSandboxDirectory() + "/_ajdump/ataspectj/DumpTestTheDump$AjcClosure1.class");
                assertTrue("Missing dump file " + f.getAbsolutePath(), f.exists());
 
-               // tidy up...
-               f = new File("_ajdump");
+               // tidy up... (should not be necessary in sandbox directory, but does not hurt)
+               f = new File(ajc.getSandboxDirectory() + "/_ajdump");
                FileUtil.deleteContents(f);
                f.delete();
        }
index a72fa4ebfc765d5e67631e035bd16a9fed8edd41..9dfc4afe4c6dacbc96e455a9b0f19bfd88351208 100644 (file)
@@ -95,7 +95,7 @@
                 options="-1.5"/>
         <run class="ataspectj.DumpTest" ltw="ataspectj/aop-dump.xml"/>
     </ajc-test>
-    
+
     <ajc-test dir="java5/ataspectj" title="LTW DumpTest before and after">
         <compile
                 files="ataspectj/EmptyAspect.aj"
         <compile
                 files="ataspectj/DumpTest.java,ataspectj/DumpTestTheDump.java,ataspectj/TestAroundAspect.aj"
                 options="-1.5"/>
-        <run class="ataspectj.DumpTest" ltw="ataspectj/aop-dumpclosure.xml"/>
+        <run class="ataspectj.DumpTest" ltw="ataspectj/aop-dumpclosure.xml" usefullltw="true"/>
     </ajc-test>
 
     <ajc-test dir="java5/ataspectj" title="LTW DumpTest proxy">
                files="ataspectj/ltwlog/Aspect1.java"
                options="-1.5 -XterminateAfterCompilation"
        >
-        </compile>     
+        </compile>
         <run class="ataspectj.ltwlog.Main" ltw="ataspectj/ltwlog/aop-silent.xml">
                <stdout>
                                <line text="execution(Main.target())"/>
                files="ataspectj/ltwlog/Aspect1.java"
                options="-1.5 -XterminateAfterCompilation"
        >
-        </compile>     
+        </compile>
         <run class="ataspectj.ltwlog.Main" ltw="ataspectj/ltwlog/aop-verbose.xml">
                <stdout>
                                <line text="execution(Main.target())"/>
                files="ataspectj/ltwlog/Aspect1.java"
                options="-1.5 -XterminateAfterCompilation"
        >
-        </compile>     
+        </compile>
         <run class="ataspectj.ltwlog.Main" ltw="ataspectj/ltwlog/aop-verboseandshow.xml">
                <stdout>
                                <line text="execution(Main.target())"/>
                files="ataspectj/ltwlog/Aspect1.java"
                options="-1.5 -XterminateAfterCompilation"
        >
-        </compile>     
+        </compile>
         <run class="ataspectj.ltwlog.Main" ltw="ataspectj/ltwlog/aop-messagehandler.xml">
                <stdout>
                                <line text="MessageHolder.MessageHolder()"/>
             files="ataspectj/ConcreteAtAspectTest.java,ataspectj/TestHelper.java"
             options="-1.5 -XterminateAfterCompilation"
             />
-        <run class="ataspectj.ConcreteAtAspectTest" ltw="ataspectj/aop-concreteataspect.xml"/>
+        <run class="ataspectj.ConcreteAtAspectTest" ltw="ataspectj/aop-concreteataspect.xml" usefullltw="true"/>
     </ajc-test>
 
     <ajc-test dir="java5/ataspectj" title="ConcreteAspect">
             files="ataspectj/ConcreteAspectTest.aj,ataspectj/TestHelper.java"
             options="-1.5 -Xdev:NoAtAspectJProcessing -XterminateAfterCompilation"
             />
-        <run class="ataspectj.ConcreteAspectTest" ltw="ataspectj/aop-concreteaspect.xml"/>
+        <run class="ataspectj.ConcreteAspectTest" ltw="ataspectj/aop-concreteaspect.xml" usefullltw="true"/>
     </ajc-test>
 
     <ajc-test dir="java5/ataspectj" title="ConcretePrecedenceAspect">
             files="ataspectj/ConcretePrecedenceAspectTest.java,ataspectj/TestHelper.java"
             options="-1.5 -Xdev:NoAtAspectJProcessing -XterminateAfterCompilation"
             />
-        <run class="ataspectj.ConcretePrecedenceAspectTest" ltw="ataspectj/aop-concreteprecedenceaspect.xml"/>
+        <run class="ataspectj.ConcretePrecedenceAspectTest" ltw="ataspectj/aop-concreteprecedenceaspect.xml" usefullltw="true"/>
     </ajc-test>
 
     <ajc-test dir="java5/ataspectj" title="AspectOfWhenAspectNotInInclude">
     </ajc-test>
 
 
-</suite>
\ No newline at end of file
+</suite>