]> source.dussan.org Git - jquery.git/commitdiff
Make sure that we don't try to double-encode params using the traditional style....
authorjeresig <jeresig@gmail.com>
Sat, 6 Feb 2010 00:43:31 +0000 (19:43 -0500)
committerjeresig <jeresig@gmail.com>
Sat, 6 Feb 2010 00:43:31 +0000 (19:43 -0500)
src/ajax.js
test/unit/ajax.js

index d0c6752788db5d7b68a657241ab354716cb14030..f514caee73bcdb9d864b547fc0e3abef08c39fea 100644 (file)
@@ -624,7 +624,7 @@ jQuery.extend({
                        // If traditional, encode the "old" way (the way 1.3.2 or older
                        // did it), otherwise encode params recursively.
                        for ( var prefix in a ) {
-                               buildParams( prefix, a[prefix] );
+                               buildParams( traditional ? prefix : prefix.replace(/[\[\]]/g, ""), a[prefix] );
                        }
                }
 
index f6809d539e5ded464c952946099f44dd9001978e..4a823ac1b098c636086235eb59b9e11ec3bf8529 100644 (file)
@@ -351,9 +351,9 @@ test("serialize()", function() {
 });
 
 test("jQuery.param()", function() {
-       expect(18);
+       expect(19);
        
-  equals( !jQuery.ajaxSettings.traditional, true, "traditional flag, falsy by default" );
+       equals( !jQuery.ajaxSettings.traditional, true, "traditional flag, falsy by default" );
   
        var params = {foo:"bar", baz:42, quux:"All your base are belong to us"};
        equals( jQuery.param(params), "foo=bar&baz=42&quux=All+your+base+are+belong+to+us", "simple" );
@@ -378,6 +378,8 @@ test("jQuery.param()", function() {
        
        params = { a:[1,2], b:{ c:3, d:[4,5], e:{ x:[6], y:7, z:[8,9] }, f:true, g:false, h:undefined }, i:[10,11], j:true, k:false, l:[undefined,0], m:"cowboy hat?" };
        equals( jQuery.param(params,true), "a=1&a=2&b=%5Bobject+Object%5D&i=10&i=11&j=true&k=false&l=undefined&l=0&m=cowboy+hat%3F", "huge structure, forced traditional" );
+
+       equals( decodeURIComponent( jQuery.param({ "test[]": [0, 1, 2] }) ), "test[]=0&test[]=1&test[]=2", "Make sure params are double-encoded." );
        
        jQuery.ajaxSetup({ traditional: true });