]> source.dussan.org Git - jquery.git/commitdiff
Event: Simplify the logic behind blacklisting Android 2.3 on one test
authorMichał Gołębiowski <m.goleb@gmail.com>
Tue, 18 Mar 2014 19:59:33 +0000 (20:59 +0100)
committerMichał Gołębiowski <m.goleb@gmail.com>
Tue, 18 Mar 2014 19:59:33 +0000 (20:59 +0100)
test/unit/event.js

index 6e5a2d09ec10c3c49e2a2e857401252be4a053e0..67fe9115b75a8af913421a822ad37911ecf27ec0 100644 (file)
@@ -387,12 +387,7 @@ test("on immediate propagation", function() {
 });
 
 test("on bubbling, isDefaultPrevented, stopImmediatePropagation", function() {
-       // Support: Android 2.3
-       if ( /android 2\.3/i.test( navigator.userAgent ) ) {
-               expect( 2 );
-       } else {
-               expect( 3 );
-       }
+       expect( 3 );
 
        var $anchor2 = jQuery( "#anchor2" ),
                $main = jQuery( "#qunit-fixture" ),
@@ -427,7 +422,9 @@ test("on bubbling, isDefaultPrevented, stopImmediatePropagation", function() {
        // Android 2.3 doesn't support stopImmediatePropagation; jQuery fallbacks to stopPropagation
        // in such a case.
        // Support: Android 2.3
-       if ( !/android 2\.3/i.test( navigator.userAgent ) ) {
+       if ( /android 2\.3/i.test( navigator.userAgent ) ) {
+               ok( true, "Android 2.3, skipping native stopImmediatePropagation check" );
+       } else {
                $anchor2.on( "click", function( e ) {
                        e.stopImmediatePropagation();
                        ok( true, "anchor was clicked and prop stopped" );