cleanup: rubocop: fix Style/MultilineIfModifier in app/models/repository/subversion.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19215 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index af6042e3dab872b3dbad419e2ff54c92fc36daac..a04b91d2bd83511fbfa1ed109d365a5bb52b8895 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1246,7 +1246,6 @@ Style/MultilineIfModifier:
     - 'app/models/issue_query.rb'
     - 'app/models/query.rb'
     - 'app/models/repository/bazaar.rb'
-    - 'app/models/repository/subversion.rb'
     - 'app/models/time_entry_query.rb'
     - 'app/views/common/feed.atom.builder'
     - 'lib/redmine/access_keys.rb'

diff --git a/app/models/repository/subversion.rb b/app/models/repository/subversion.rb
index f6e37fbd657f39adc66c45757be99d18fc6e7619..c42ffd4959eb01344238a6e22b94f34336cd429f 100644 (file)
--- a/app/models/repository/subversion.rb
+++ b/app/models/repository/subversion.rb
@@ -68,19 +68,22 @@ class Repository::Subversion < Repository
           # loads changesets by batches of 200
           identifier_to = [identifier_from + 199, scm_revision].min
           revisions = scm.revisions('', identifier_to, identifier_from, :with_paths => true)
-          revisions.reverse_each do |revision|
-            transaction do
-              changeset = Changeset.create(:repository   => self,
-                                           :revision     => revision.identifier,
-                                           :committer    => revision.author,
-                                           :committed_on => revision.time,
-                                           :comments     => revision.message)
-
-              revision.paths.each do |change|
-                changeset.create_change(change)
-              end unless changeset.new_record?
+          unless revisions.nil?
+            revisions.reverse_each do |revision|
+              transaction do
+                changeset = Changeset.create(:repository   => self,
+                                             :revision     => revision.identifier,
+                                             :committer    => revision.author,
+                                             :committed_on => revision.time,
+                                             :comments     => revision.message)
+                unless changeset.new_record?
+                  revision.paths.each do |change|
+                    changeset.create_change(change)
+                  end
+                end
+              end
             end
-          end unless revisions.nil?
+          end
           identifier_from = identifier_to + 1
         end
       end