Offset: Send px-ed strings to .css()

An upcoming release of Migrate will generate warnings for calls to .css() that pass numbers rather than strings, see jquery/jquery-migrate#296 . At the moment, core's .offset() setter passes numbers rather than px strings so it would throw warnings. This commit fixes that.

Closes gh-4508

diff --git a/src/offset.js b/src/offset.js
index 6e973587062b47e09a5e5bcc58bf2e1988bad5a3..62166bc9999f37838abf3544aa62876cfcc25727 100644 (file)
--- a/src/offset.js
+++ b/src/offset.js
@@ -63,6 +63,12 @@ jQuery.offset = {
                        options.using.call( elem, props );
 
                } else {
+                       if ( typeof props.top === "number" ) {
+                               props.top += "px";
+                       }
+                       if ( typeof props.left === "number" ) {
+                               props.left += "px";
+                       }
                        curElem.css( props );
                }
        }