]> source.dussan.org Git - jgit.git/commitdiff
DHT: Always have at least one recent chunk in DhtReader 06/3706/1
authorShawn O. Pearce <spearce@spearce.org>
Fri, 10 Jun 2011 00:55:52 +0000 (17:55 -0700)
committerShawn O. Pearce <spearce@spearce.org>
Fri, 10 Jun 2011 00:55:52 +0000 (17:55 -0700)
The RecentChunks cache assumes there is always at least one recent
chunk in the maxSize that it receives from the DhtReaderOptions.
Ensure that is true by requiring the size to be at least 1.

Running with 0 recent chunk cache is very a bad idea, often
during commit walking the parents of a commit will be found
on the same chunk as the commit that was just accessed. In
these cases its a good idea to keep that last chunk around
so the parents can be quickly accessed.

Change-Id: I33b65286e8a4cbf6ef4ced28c547837f173e065d
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
org.eclipse.jgit.storage.dht/src/org/eclipse/jgit/storage/dht/DhtReaderOptions.java

index 0890e39ad029637c675d53545d54439cd7823734..8376e2b6bad6dbad986d6bf2eafb150bc2795ba1 100644 (file)
@@ -240,7 +240,7 @@ public class DhtReaderOptions {
         * @return {@code this}
         */
        public DhtReaderOptions setRecentChunkCacheSize(int chunkCnt) {
-               recentChunkCacheSize = Math.max(0, chunkCnt);
+               recentChunkCacheSize = Math.max(1, chunkCnt);
                return this;
        }