sonar issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903687 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/OPCPackage.java b/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/OPCPackage.java
index 0fc4c624be3fc7a997410b7c444a97b8ebd90e25..4625a940ed09e4251d0898bef5de4b03c30c2138 100644 (file)
--- a/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/OPCPackage.java
+++ b/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/OPCPackage.java
@@ -282,7 +282,7 @@ public abstract class OPCPackage implements RelationshipSource, Closeable {
            throw new IllegalArgumentException("file must not be a directory");
        }
 
-       OPCPackage pack = new ZipPackage(file, access);
+       OPCPackage pack = new ZipPackage(file, access); //NOSONAR
        try {
            if (pack.partList == null && access != PackageAccess.WRITE) {
                pack.getParts();

diff --git a/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java b/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java
index 82359fe80bfe1d7c101adf415e4f521a7c633761..9df140d41446d3eab3d68ef5ec24f206a6347111 100644 (file)
--- a/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java
+++ b/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java
@@ -234,7 +234,11 @@ import org.apache.poi.util.Internal;
     public boolean untrackColumns(Collection<Integer> columns)
     {
         untrackedColumns.addAll(columns);
-        return maxColumnWidths.keySet().removeAll(columns);
+        boolean result = false;
+        for (Integer col : columns) {
+            result = maxColumnWidths.remove(col) != null || result;
+        }
+        return result;
     }
     
     /**
@@ -248,7 +252,7 @@ import org.apache.poi.util.Internal;
      */
     public boolean untrackColumn(int column) {
         untrackedColumns.add(column);
-        return maxColumnWidths.keySet().remove(column);
+        return maxColumnWidths.remove(column) != null;
     }
 
     /**