apply rules page feedback

diff --git a/server/sonar-web/src/main/hbs/coding-rules/rule/coding-rules-custom-rules.hbs b/server/sonar-web/src/main/hbs/coding-rules/rule/coding-rules-custom-rules.hbs
index 4e03b21754d729f95ad484a111bc262ac0b8ef65..36a79d1951ab2426d70028ccccd32eec0e267fd9 100644 (file)
--- a/server/sonar-web/src/main/hbs/coding-rules/rule/coding-rules-custom-rules.hbs
+++ b/server/sonar-web/src/main/hbs/coding-rules/rule/coding-rules-custom-rules.hbs
@@ -1,4 +1,6 @@
 <div class="coding-rules-detail-custom-rules-section">
+  <div class="coding-rule-section-separator"></div>
+
   <h3 class="coding-rules-detail-title">{{t 'coding_rules.custom_rules'}}</h3>
 
   {{#if canWrite}}

diff --git a/server/sonar-web/src/main/hbs/coding-rules/rule/coding-rules-rule-issues.hbs b/server/sonar-web/src/main/hbs/coding-rules/rule/coding-rules-rule-issues.hbs
index fd7628139e0dd710d2cd1b32ae50dcbae631cce5..e60656f4dd00df49cf66762113700c3b47302e53 100644 (file)
--- a/server/sonar-web/src/main/hbs/coding-rules/rule/coding-rules-rule-issues.hbs
+++ b/server/sonar-web/src/main/hbs/coding-rules/rule/coding-rules-rule-issues.hbs
@@ -1,3 +1,5 @@
+<div class="coding-rule-section-separator"></div>
+
 <h3 class="coding-rules-detail-title">
   {{t 'coding_rules.issues'}} (<a class="js-rule-issues" href="{{baseSearchUrl}}" target="_blank">{{total}}</a>)
 </h3>

diff --git a/server/sonar-web/src/main/hbs/coding-rules/rule/coding-rules-rule-profiles.hbs b/server/sonar-web/src/main/hbs/coding-rules/rule/coding-rules-rule-profiles.hbs
index 629206a91625c46e4d526ce9aff7115d15e141b1..cea2bdaa79900534edc26c61c3af73a98463c8fb 100644 (file)
--- a/server/sonar-web/src/main/hbs/coding-rules/rule/coding-rules-rule-profiles.hbs
+++ b/server/sonar-web/src/main/hbs/coding-rules/rule/coding-rules-rule-profiles.hbs
@@ -1,4 +1,6 @@
 <div class="coding-rules-detail-quality-profiles-section">
+  <div class="coding-rule-section-separator"></div>
+
   <h3 class="coding-rules-detail-title">{{t 'coding_rules.quality_profiles'}}</h3>
 
   {{#if canWrite}}

diff --git a/server/sonar-web/src/main/js/coding-rules/rule-details-view.js b/server/sonar-web/src/main/js/coding-rules/rule-details-view.js
index 7e4cd25237f64b5c49197ff36f38e3a09aeeba56..df9c3803e89113bd3c8d94cd04712c73c0dd0e74 100644 (file)
--- a/server/sonar-web/src/main/js/coding-rules/rule-details-view.js
+++ b/server/sonar-web/src/main/js/coding-rules/rule-details-view.js
@@ -118,7 +118,7 @@ define([
             that.options.app.controller.showDetailsForSelected();
             return false;
           });
-          key('left', 'details', function () {
+          key('left, backspace', 'details', function () {
             that.options.app.controller.hideDetails();
             return false;
           });

diff --git a/server/sonar-web/src/main/less/components/rules.less b/server/sonar-web/src/main/less/components/rules.less
index 4532f47ba93d09d8b6ae6a7116e239969dd1b6e3..3ca1bb28115423b4262824856311ef97f9b0d9f8 100644 (file)
--- a/server/sonar-web/src/main/less/components/rules.less
+++ b/server/sonar-web/src/main/less/components/rules.less
@@ -76,9 +76,10 @@
   padding-left: 20px;
 }
 
-.coding-rule-section > div {
-  max-width: 1020px;
+.coding-rule-section-separator {
+  height: 10px;
   margin: 0 -10px;
-  padding: 0 10px;
-  border-top: 10px solid @barBackgroundColor;
+  border-top: 1px solid @barBorderColor;
+  border-bottom: 1px solid @barBorderColor;
+  background-color: @barBackgroundColor;
 }

diff --git a/server/sonar-web/src/main/less/components/typography.less b/server/sonar-web/src/main/less/components/typography.less
index bdc8903a45c35732a688efa910d6f8bb08c80ea0..4fdf5a5393ecb6f2206ff90e46cf6c90f13e5531 100644 (file)
--- a/server/sonar-web/src/main/less/components/typography.less
+++ b/server/sonar-web/src/main/less/components/typography.less
@@ -3,7 +3,6 @@
 @import (reference) "ui";
 
 .formatted() {
-  max-width: 1020px;
   line-height: 1.5;
 
   p, ul, ol, pre, blockquote, table, h2, h3, h4, h5, h6 {
@@ -26,7 +25,6 @@
   }
 
   pre {
-    max-width: 1020px;
     padding: 10px;
     border-top: 1px solid @barBorderColor;
     border-bottom: 1px solid @barBorderColor;

diff --git a/server/sonar-web/src/main/less/pages/coding-rules.less b/server/sonar-web/src/main/less/pages/coding-rules.less
index e32da3d4c3315f5068091969760def8e0003354c..9a83be95b43e7d6cc636d1899978ff9ea27664fe 100644 (file)
--- a/server/sonar-web/src/main/less/pages/coding-rules.less
+++ b/server/sonar-web/src/main/less/pages/coding-rules.less
@@ -411,3 +411,18 @@ textarea.coding-rules-markdown-description {
 
   .icon-tags:before { font-size: 12px; }
 }
+
+.coding-rules-most-violated-projects {
+
+  td {
+    border-top-color: transparent;
+  }
+
+  tr:first-child + tr td {
+    border-top-color: @barBorderColor;
+  }
+
+  .coding-rules-detail-list-name {
+    font-weight: 400;
+  }
+}